codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Show pro tip in cases for multiple flags with one upload #201

Closed codecovdesign closed 1 month ago

codecovdesign commented 1 year ago

Problem to solve

Proper configuration should result in 1 flag per upload. Sometimes, misconfiguration leads to multiple flags in the upload aside.

Solution

Display some visual treatment in the form of “pro-tip“ or in app troubleshooting to helps user understand this discrepancy.

The ask here is to show it as an error message and provide solution for the fix. Screenshot 2024-04-16 at 1 01 11 PM

Figma designs [This is not the latest design]

Figma: link

Adal3n3 commented 7 months ago

@codecovdesign The upload error reporting issue https://github.com/codecov/engineering-team/issues/1086 has covered this flag error. We can decouple the error messages here as well.

https://github.com/codecov/engineering-team/issues/1086#issuecomment-2043697083

Adal3n3 commented 7 months ago

Figma: link

The ask here is just update the flag error message.

Screenshot 2024-04-09 at 11 48 56 AM

Adal3n3 commented 6 months ago

@katia-sentry Can you prioritize this? You will see this "Multiple flags" error on the Upload error reporting issue which they are the same https://github.com/codecov/engineering-team/issues/1086 If you prefer to decouple the fixes we can keep this issue or close this issue as it'll be covered from issue 1086. What do you think?

Adal3n3 commented 1 month ago

If we can't do https://github.com/codecov/engineering-team/issues/2498 this is 1 day eng work