codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Team upgrade button shows broken /upgrade page #2051

Closed aj-codecov closed 1 month ago

aj-codecov commented 1 month ago

Describe the bug When clicking upgrade from the Team plan box, it shows the "pro" and "annual" boxes highlighted, but shows the team plan pricing - clicking "proceed to checkout" for me in a Sentry connected account then takes me to the stripe checkout page showing I selected the Sentry pro plan. Clicking any button on the /upgrade page causes it to fix itself and the stripe page to display properly.

The box on the lefthand side of the /upgrade page shows the team plan with pro highlighted on the right.

The pricing info at the bottom is actually reflective of the team plan.

Screenshot 2024-07-09 at 14 35 08

To Reproduce Steps to reproduce the behavior:

  1. In an account with less than 10 activated users
  2. Plan page
  3. Click upgrade from Team plan box
  4. be confused

Expected behavior Upgrade button from Team plan box should default to Team actually being selected.

eliatcodecov commented 1 month ago

Could be an issue where the page loads defaults instead of loading the customer's current plan. This was previously fixed, likely a regression.

ajay-sentry commented 1 month ago

@eliatcodecov @aj-codecov Running this on Local and not seeing the same behavior. Looks like it's defaulting to Team for team plans o_O

Can we double check?

ajay-sentry commented 1 month ago

Oh wait I see, it's upgrade page not Manage page. Double checking

ajay-sentry commented 1 month ago

https://github.com/user-attachments/assets/b22efd31-7657-4af8-9db2-f3c27df9a9db

Yep, still not seeing this 🤔