search

codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

{GA Launch Prep} Add seat enforce logic to TestResultFinisher #2264

Closed rohan-at-sentry closed 2 weeks ago

rohan-at-sentry commented 1 month ago

Test Analytics users can currently use it completely free without limits on # of uploads or # of activated seats that might be uploading reports.

Solution: We need to gate on activation for private repo usage of TA, no change to public repo usage. If a user opens a PR on a private repo and is not activated they should auto-activate if auto activate is turned on - if it is not on, the user should receive our standard "please activate your user to see Codecov message that we show for coverage" - we should be careful not to double spam the message if coverage is already going to surface that message.

Autoactivation code in notify: https://github.com/codecov/worker/blob/ca5d0dd5a64579ec0e5c47a3af57285644816fba/tasks/notify.py#L663 and look at https://github.com/codecov/worker/blob/ca5d0dd5a64579ec0e5c47a3af57285644816fba/tasks/notify.py#L676

rohan-at-sentry commented 1 month ago

Also related for BA - https://github.com/codecov/engineering-team/issues/2254