codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Patch coverage calculation by git diff and head commit for commits #2346

Open aj-codecov opened 1 month ago

aj-codecov commented 1 month ago

Some time ago we shifted our patch coverage on pull requests to be determined by the git diff and coverage of the head, thereby eliminating a need for a base commit and providing accurate coverage more often.

Did we do the same thing for commits? It appears today like we may still be using an older base/head style comparison to determine patch coverage on commits (not pulls).

If we are still using the old logic we should shift to the updated diff+head coverage method.

rohan-at-sentry commented 1 month ago

https://github.com/codecov/engineering-team/issues/887 was shipped.