search

codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Okta auth banner not appearing #2460

Open codecovdesign opened 3 weeks ago

codecovdesign commented 3 weeks ago

Describe the bug Regarding Okta Auth – in the scenario that a user is logged in and is attempting to land on org/repo there is only an empty state instead of including the intended top level banner to require auth. (initially reported by @nicholas-codecov )

Image

To Reproduce Steps to reproduce the behavior:

  1. Go to a org/repo that has okta enabled
  2. Notice on the org/repo there is no banner (but there is on org)

Expected behavior When an org is selected no matter what page and IF user is logged in and part of org the empty state should include the login auth (+ top level nav elemetns (org selector, ?, user avatar - should still be visible)

Image

suejung-sentry commented 2 weeks ago

Note to self - I'd summarize this as "Fix so fallback error screens include Headers, where possible"

Image