search

codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

PR comment to app navigation section not expanded (when coverage and bundle are both configured) #2487

Open codecovdesign opened 1 month ago

codecovdesign commented 1 month ago

Describe the bug When user clicked specific file it lead to the following (from PR comment: https://github.com/getsentry/sentry/pull/77049):

Image

The problem is that the respective file should have been displayed / active, which is once you open the coverage section.

Image

The issue is the coverage section was not open, and the individual file wasn't visible due to this (which is working as intended it appears)

To Reproduce Steps to reproduce the behavior:

  1. From PR comment click file missing coverage
  2. See the sections page not expanded (IF bundle is included)

Expected behavior IF coverage related file was clicked, that section should be open so user can see the respective file as they expected

Adal3n3 commented 1 month ago

We fixed this issue not long ago: https://github.com/codecov/engineering-team/issues/1448

Even show the highlight on what line is uncovered. https://github.com/codecov/engineering-team/issues/941

cc @katia-sentry @codecovdesign

codecovdesign commented 1 month ago

@Adal3n3 this issue is a bit different - the issues you linked work as intended 🎉 however, in this case the user is in this PR comment and selects file release.py, they'd expect to see the respective file in app with the chunk open. but it shows this (in scenario both bundle AND coverage configured):

Image

then they are forced to expand coverage section, good news is once they expand, the link they initially clicked for is open, as intended:

Image