codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Transformed yaml for codecov #2488

Open codecovdesign opened 2 months ago

codecovdesign commented 2 months ago

Problem to solve

Today, we take the repo yaml input from customer and transform it to internal representation/copy to parse. The issue is then in the UI we show the internal representation instead of the intended yaml that the customer input.

Image Image Image

Solution

Display the intended yaml as per the customer input

thomasrockhu-codecov commented 2 months ago

@codecovdesign I'm not sure this a bug, it seems like this was the original behavior. Tagging as a feature request

codecovdesign commented 2 months ago

@thomasrockhu-codecov this is not showing the yaml the customer input but our internal translation of it, @drazisil-codecov and I were troubleshooting it earlier. happy to jump on a quick sync to review!

drazisil-codecov commented 2 months ago

This is technically a feature request, I agree with @thomasrockhu-codecov , regardless of how annoying it is.

@codecovdesign This will need a scoped investigation and planning, since I don't think we save the original YAML anywhere, so it's not as easy as "just display it". 😬

codecovdesign commented 2 months ago

do you all think we should raise it at bug sync for next steps? to the user they don't expect this and/or know what the extra inputs are 🤔

drazisil-codecov commented 2 months ago

Can't hurt to discuss it briefly, unless Tom disagrees.

thomasrockhu-codecov commented 2 months ago

That's fine, we can discuss. I don't think, however, that this will be solvable in bug sync

eliatcodecov commented 1 month ago

My intuition is that this unsolvable as an isolated bug, there are too many interdependencies being discussed already in #1028 . We'll triage this, but it will likely get solved as part of larger work.