search

codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Darkmode Text Color Should be Different #2501

Open calvin-codecov opened 2 months ago

calvin-codecov commented 2 months ago

Describe the bug "Not enough data to render" text color isn't changing from light vs dark mode

Ex: https://app.codecov.io/github/codecov/codecov-api/tree/joseph%2Fimprove-aggregate

To Reproduce Steps to reproduce the behavior:

  1. Go to coverage tab for codecov-api
  2. Find a branch that doesn't have enough data

Expected behavior Color should get lighter for dark mode.

Screenshots Image Image

Adal3n3 commented 1 month ago

@calvin-codecov Thanks for documenting this issue. I don't see the "Not enough data to render" on my end, that's interesting. Looking at the screenshot, where does the 95% coverage come from if there is not enough data to render? Would it be a bug trigger this message? Maybe @nicholas-codecov can help.

calvin-codecov commented 1 month ago

@Adal3n3 we are showing "not enough data" when there is only one data point.

Adal3n3 commented 1 month ago

The text color should be --color-ds-gray-octonary: 234, 235, 239; (light grey)