search

codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Not enough data to display #2676

Open Adal3n3 opened 3 weeks ago

Adal3n3 commented 3 weeks ago

The UI says "Not enough data to display" but we still display the data. We should not display the data if there has not enough data to display.

Related issue: https://github.com/codecov/engineering-team/issues/2501 https://github.com/codecov/engineering-team/issues/2566

Screenshots Image Image

Adal3n3 commented 2 days ago

@calvin-codecov and I discussed the turn around on this issue is remove the UI copy because we do have one data point to display and it's not a problem.

nicholas-codecov commented 2 days ago

@katia-sentry as part of #2770 I've done some work around this, not displaying the chart and just the message to users:

Image

cc @calvin-codecov

If we do require more changes, are we able to hold off on that work until the new charts have been rolled out? Should be before end of my day today PR's are open.

katia-sentry commented 2 days ago

Makes sense holding off on this work for new charts. @calvin-codecov let's get the new charts in before addressing this ticket and https://github.com/codecov/engineering-team/issues/2501.