codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Investigate header updates #460

Closed katia-sentry closed 6 months ago

katia-sentry commented 1 year ago

design overview

We need to investigate work related to login page, sync page and onboarding selector page based on designs - this includes different header scenarios.

AC

nicholas-codecov commented 1 year ago

Question for @codecovdesign, you've brought the upgrade trial link from the tab nav up next to the the ? dropdown, wondering if you want that trial reminder present on the context selector header and the breadcrumb header?

nicholas-codecov commented 1 year ago

These change most certainly should be put behind a feature flag so that we can break this task down in a manner that PRs don't grow in too much size too quickly.

nicholas-codecov commented 1 year ago

Another question for @codecovdesign, on the avatar drop down there's a select default org button to open the modal, not sure this is possible with the changes previously made. Currently whenever you navigate between orgs it sets that org as your default so you're returned where you left off last time.

Are we looking at removing that behaviour to add in this default org selector modal again?

nicholas-codecov commented 1 year ago

Another quick question for you @codecovdesign is how are we going to handle the top banners that use to be placed directly under the current nav bar?

aj-codecov commented 1 year ago
  1. We'd like to keep the trial reminder
  2. We are not re-adding the default org selector functionality
  3. Re: top banners... i don't know, we could put it all the way at the top and push the page down when a banner is resent, but that can be a little janky sometimes, I'm not sure we have a solution in this case - open to ideas!
nicholas-codecov commented 1 year ago

Okay perfect thank you

nicholas-codecov commented 1 year ago

@aj-codecov do you have any knowledge around the updated links in the information architecture section? It looks like the new logo button should link to the plan page? As well I'm really confused with the links under the Turing Corp dropdown.

nicholas-codecov commented 1 year ago

Also when running in self hosted we're gonna show the seat count and for admins the admin link, however the admin settings page for self hosted isn't tied to an organization, so we can't really show a context select. Can we get some designs for the expected behaviour of that page.

Currently we are showing a breadcrumb with the first entry being a link to the default org of the current viewing user.

aj-codecov commented 1 year ago

@nicholas-codecov Logo should not link to the plan page - should just take you to org: codecov.io/gh/codecov for example Dropdown under the org is just the standard org selector - I believe the following is referring to the breadcrumb at the top, not as a dropdown.

Screenshot 2023-09-28 at 7 53 40 AM

Designs needed for SH, gottttt it

nicholas-codecov commented 1 year ago

@codecovdesign A few things to take a peak at, please and thank you.