Closed katia-sentry closed 9 months ago
Talk to Joe about this bug for more context
wait_for_ci is not used in the pulls_sync task, it only triggers the notify task. The notify task then checks for the wait_for_ci and does the notifications accordingly. see here I don't see this as a bug since we do check the wait_for_ci. Maybe this was a user specific issue
I'm going to reopen this.
Here is a reproduction showing that notifications from web hooks do not honor the wait_for_ci
setting
https://sentry.rewatch.com/video/itpp4z66mvx3p7o0-rewatch-screen-recording-2023-06-28-at-1-41-11-pm
@katia-sentry , @scott-codecov Let me know if this should be reassigned since Dana is on vacation.
cc: @trent-codecov
leaving trace of ticket to follow up on when needed..https://sentry.zendesk.com/agent/tickets/98329
@trent-codecov Should that status change have closed this?
Ticket: https://codecov.freshdesk.com/a/tickets/8642
Ask: Is there any way to disable webhook processing at the repo level? The customer wants us to wait to send notifications (such as "PR mismatch") to the PR until all coverage reports are uploaded. wait_for_ci is ignored by the pulls_sync task.
Issue created in Slack from a message.
https://github.com/codecov/worker/blob/8740ca66d10e8fe17776c8a8fb8662226070a664/tasks/sync_pull.py#L96
jira: https://codecovio.atlassian.net/browse/CODE-2374