codecov / engineering-team

This is a general repo to use with GH Projects
2 stars 1 forks source link

Since the sync_pulls task ignores wait_for_ci, is there another way to disable webhook processing? #5

Closed katia-sentry closed 9 months ago

katia-sentry commented 1 year ago

Ticket: https://codecov.freshdesk.com/a/tickets/8642

Ask: Is there any way to disable webhook processing at the repo level? The customer wants us to wait to send notifications (such as "PR mismatch") to the PR until all coverage reports are uploaded. wait_for_ci is ignored by the pulls_sync task.

Issue created in Slack from a message.

https://github.com/codecov/worker/blob/8740ca66d10e8fe17776c8a8fb8662226070a664/tasks/sync_pull.py#L96

jira: https://codecovio.atlassian.net/browse/CODE-2374

katia-sentry commented 1 year ago

Talk to Joe about this bug for more context

dana-yaish commented 11 months ago

wait_for_ci is not used in the pulls_sync task, it only triggers the notify task. The notify task then checks for the wait_for_ci and does the notifications accordingly. see here I don't see this as a bug since we do check the wait_for_ci. Maybe this was a user specific issue

drazisil-codecov commented 11 months ago

I'm going to reopen this.

Here is a reproduction showing that notifications from web hooks do not honor the wait_for_ci setting

https://sentry.rewatch.com/video/itpp4z66mvx3p7o0-rewatch-screen-recording-2023-06-28-at-1-41-11-pm

@katia-sentry , @scott-codecov Let me know if this should be reassigned since Dana is on vacation.

drazisil-codecov commented 11 months ago

cc: @trent-codecov

jessecodecov commented 11 months ago

leaving trace of ticket to follow up on when needed..https://sentry.zendesk.com/agent/tickets/98329

dana-yaish commented 10 months ago

https://github.com/codecov/worker/pull/50

drazisil-codecov commented 9 months ago

@trent-codecov Should that status change have closed this?