search

codecov / engineering-team

This is a general repo to use with GH Projects
2 stars 1 forks source link

Add notification loading to PR comment #553

Closed katia-sentry closed 7 months ago

katia-sentry commented 8 months ago

problem: the PR comment report doesn't appear until the first notification (Codecov worker sending information back to GH) is ready. solution: Add a simple indicator to the comment on the PR saying "Processing". Then update when we have data.

katia-sentry commented 8 months ago

Context: Screenshot 2023-09-26 at 2 37 43 PM

scott-codecov commented 8 months ago

@katia-sentry Should the comment literally just say "Processing" or do we have some additional copy?

katia-sentry commented 8 months ago

@codecovdesign @aj-codecov What do you think? do we need a better copy that "Processing" here? Maybe "Processing report"?

scott-codecov commented 8 months ago

I currently have it as:

We're currently processing your upload. This comment will be updated when the results are available.

katia-sentry commented 7 months ago

@aj-codecov @codecovdesign can you confirm ^

aj-codecov commented 7 months ago

@scott-codecov Copy is perfect!

scott-codecov commented 7 months ago

I rolled this back due to an issue that a customer was seeing. We can see in this log entry that the initial PR comment was made and the comment ID was returned: https://l.codecov.dev/UKZHN3 But when we look in the database the pulls.commentid column for that PR is null. We use the presence of that commentid to determine whether we've already made a comment for that PR and so we were continuing to send the "We're currently processing your upload" comment.

Need to figure out why that commentid could possibly be null in this case.