codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Pulls/Commits list error messaging #749

Open aj-codecov opened 11 months ago

aj-codecov commented 11 months ago

Problem to solve

In the table there are cases when the errors below happen and then the tris unable to show data.

Screenshot 2023-11-07 at 10 09 40 AM
query Commit ``` graphql query Commit( $owner: String! $repo: String! $commitid: String! $filters: ImpactedFilesFilters ) { owner(username: $owner) { repository(name: $repo) { __typename ... on Repository { commit(id: $commitid) { compareWithParent { __typename ... on Comparison { indirectChangedFilesCount directChangedFilesCount state patchTotals { coverage: percentCovered } impactedFiles(filters: $filters) { __typename ... on ImpactedFiles { results { patchCoverage { coverage: percentCovered } headName baseCoverage { coverage: percentCovered } headCoverage { coverage: percentCovered } } } ... on UnknownFlags { message } } } ... on FirstPullRequest { message } ... on MissingBaseCommit { message } ... on MissingHeadCommit { message } ... on MissingComparison { message } ... on MissingBaseReport { message } ... on MissingHeadReport { message } } } } ... on NotFoundError { message } ... on OwnerNotActivatedError { message } } } } ```

Then need to link user to respective PR / Commit page:

Screenshot 2023-11-07 at 10 10 26 AM

Separate, @codecovdesign ToDo create separate issue to improve PR / Commit error state. NOTE TO ADD: the banner is shown on multiple pages, but is not needed in some cases. Said differently, data that could be shown should be shown.

Solution ideation

Adal3n3 commented 6 months ago

@aj-codecov So the new table will cover this problem. If the is unable to show the data, we will show "-" to indicate no value.

Screenshot 2024-03-15 at 12 25 37 PM