codecov / engineering-team

This is a general repo to use with GH Projects
1 stars 1 forks source link

Repo config instructions check image mismatch #907

Open codecovdesign opened 10 months ago

codecovdesign commented 10 months ago

Problem to solve

When a repo is not yet configured the steps to do so appear in-app. There is an image that shows the check for first PR, which has been reported to be different.

from guide (expected)

Screenshot 2023-12-08 at 9 11 18 AM

reported by user (unexpected) image

Solution

MichaelHinrichs commented 10 months ago

I'm the person who reported this problem. I've fiddled around with the yml file a bit.

jobs:
  coverage:
    name: codecov
    runs-on: ${{ matrix.os }}
    strategy:
      matrix:
        os: [macos-latest, windows-latest, ubuntu-latest]

Now i get this. CodecovChecks

One check for each OS makes sense, but now the checks for the pull request are gone, even though i didn't touch that part of the yml file at all.

on:
  push:
    branches:
      - main
      - CodecovBranch
  pull_request:
    branches:
      - main
      - CodecovBranch

And there's still no sign of "codecov/patch" or "codecov/project" with the pink logo. I still don't understand what the words to the right of the slash mean. I know they can't be branch names, because i named my branch to be clear that it is the branch, and not the workflow, job, or step, also named codecov. But in another repo that got it right, i don't see anything named "patch" or "project" anywhere in the workflow. https://github.com/sanic-org/sanic/blob/main/.github/workflows/coverage.yml