Closed kylemann closed 1 year ago
I understand now. So, the bad design choice in the new UI is that they are trying to show both the changes in code coverage and the textual diff in the same interface. This explains why codecov has been so obstinate in keeping the change to how coverage is shown only in the left margin rather than across the whole line, see: 1, 2, 3.
Reading the coverage takes more effort now, so this is a regression. I don't use codecov for text diffs. I use GitHub for text diffs, which is much better at it. for example you can paste someone a link to a specific line (can't do that on codecov).
trying to show both the changes in code coverage and the textual diff in the same interface
@vinniefalco the screenshots you are referring in your comment (exception 2nd), with the both coverage and textural diff, are the old UI. The new UI does not show the git diff, at this time. However, it is under review and we do receive some positive feedback about that view.
his explains why codecov has been so obstinate in keeping the change to how coverage is shown only in the left margin
This is temporary and we're ideating on visual designs to show highlight across the line, while also accounting for other data overlays for other features and/or potential integrations. We've heard the feedback and are on it! 🙏
I'm just gonna throw this out there, but the proportional font looks better than the monospaced one:
Yes obviously, a proportional font can't possibly work for showing source code but if we are only evaluating the quality of the letterforms and how well they look when zoomed, the proportional font had a higher quality.
note "I prefer something like this" is part of the image and not my exposition.
What would you'd like to see improved?
We have a lot of files in our repository and here's how "Coverage report" looks like on CodeCov:
It seems the layout of the left column is relative to the length of the right column, which is unexpected. I have to scroll down several pages to see this:
This is kind of inconvenient for a UI :slightly_frowning_face:
I tested out the new UI when viewing the coverage changes for a commit and went back to the old UI for one main reason:
I couldn't figure out how to see coverage delta (as caused by my commit) in the new UI. By default it just showed covered or uncovered lines. (I might be missing something but showing coverage delta was the default view in the old UI!)
How do I get to the Files grid from here? https://app.codecov.io/gh/vinniefalco/http_proto/commit/fd8244dba3f6a652f9af89f32d7d8f26f8e3411c
This is the Files grid:
@vinniefalco
How do I get to the Files grid from here? https://app.codecov.io/gh/vinniefalco/http_proto/commit/fd8244dba3f6a652f9af89f32d7d8f26f8e3411c
Sounds like you are looking to see "all files" in the respective commit? Is that correct? At this time, the new commit UI does not have an all files view. However, this is the minimal state and will have that capability in a future release. To view all files per commit: you can switch to the former UI in the banner, the files grid is available in that context.
What would you'd like to see improved?
We have a lot of files in our repository and here's how "Coverage report" looks like on CodeCov:
It seems the layout of the left column is relative to the length of the right column, which is unexpected. I have to scroll down several pages to see this:
This is kind of inconvenient for a UI 🙁
Hey @alalazo, thanks a lot for your feedback! We have recently addressed this issue. The area will always have an appropriate height and it will always be visible as you scroll down.
@mdabrowski1990 we are in process of building features around this:
separate graphs for each flag (total and each flag to be separated) separate history of coverage for each flag (total and each flag to be separated)
Could we tap you for when we are ready for early access?
@jerrodcodecov I would be more than happy.
Where are these tabs in the new design? Specifically I'm interested in "Files" because I often want to check the coverage of unchanged files for a given commit.
I just made a commit, and the new UI indicates that it occurred in the future because it seems that the UI uses UTC while the commit occurred in US Eastern time.
See the text just below "improve testing" around the middle top to bottom, on the left:
Where are these tabs in the new design? Specifically I'm interested in "Files" because I often want to check the coverage of unchanged files
@Tyrrrz it was not released with the new UI, yet. However, it will be included in future releases.
made a commit, and the new UI indicates that it occurred in the future because it seems that the UI uses UTC
@billdenney thank you for the report 🙏 . Looks like it's a bug we are now fixing.
Hello! I didn't find this warning in the new version of UI
It is very helpful, and would be nice to have it in new UI
I haven't checked if it was reported already, but my timezone for displaying the commit time is not correctly taken into account at the moment: "about 2 hours ago" whereas in fact it was more like 1 minute ago.
Coverage sunburst long paths
For the coverage sunburst, it'd be great to see the full path as mouseover tooltip. Otherwise, one has to click on the link to see the full name, especially in Java where you have long paths due to the package naming.
@Splines hey is that coverage sunburst accurate for your project? You have some work to do :)
@vinniefalco Yeah, for sure working on it... Just served as a demonstration ;)
A shared "Repository Upload Token" would be handy. (eg. "General Upload Token" for all repositories).
Instead of storing Encrypted Secrets for each separate repository, a single Encrypted secret can be stored in the Organization settings.
For secrets stored at the organization-level, you can use access policies to control which repositories can use organization secrets. Organization-level secrets let you share secrets between multiple repositories, which reduces the need for creating duplicate secrets. Updating an organization secret in one location also ensures that the change takes effect in all repository workflows that use that secret. -- GitHub
How do I get to the all files view from here in the new interface; https://app.codecov.io/gh/vinniefalco/http_proto/commit/61ab7b2ecb0436b21784b7e3390c7baf5df0106f
That is, how do I get to here:
@vinniefalco Thank you for your feedback, at the moment you can still switch back to the old view to access all files view, there's a WIP to bring this to the new UI soon.
From our organization's landing page that list all of our repos, when I click on one of our connect repos, I get a Error 500 page. This happens every time and with any repo. Please advise
From our organization's landing page that list all of our repos, when I click on one of our connect repos, I get a Error 500 page. This happens every time and with any repo. Please advise
Hi, @andrewle Could you please file this issue with our support team here https://codecov.freshdesk.com/support/tickets/new
That'll allow them to come back to you directly with any follow-up questions and answers.
Thank you!
Hi @lonico, please refer to this doc https://docs.codecov.com/docs/unexpected-coverage-changes
Hi, not sure if this has been mentioned yet, but the setup page for a new project (i.e. https://app.codecov.io/gh/<org>/<repo>/new
) gives the wrong environment variable key (Codecov Token
should be CODECOV_TOKEN
).
Some sort of log would be helpful. I'm always navigating in the dark trying to find out why a comment is not being posted, why uploads fail, ...
It would be nice for the colors to be more colorblind friendly, I really have a hard time seeing which lines are tested and which lines are not.
I'm finding the diff view difficult to understand.
I have no idea what is going on here and can only assume it's a bug
only assume it's a bug
@MetRonnie yes, looks like some visuals and reporting behavior there are not rendering properly. I've filed and bug report and it will be updated soon. Thank you for the screenshoot / heads up! 🙏
would be nice for the colors to be more colorblind friendly
@adrinjalali agreed, and it's in progress for upcoming iterations. We have added some texture background to uncovered/partials, as seen in the screen shot above (w/ a bug as reported). In interim, there is the ability to toggle off covered lines at the top; this way you'd only see uncovered. Not ideal, I know, but more updates to come will help this. Thank you for the feedback 🙏
I want to upgrade to a paid plan, but it's impossible.
First, when I click on the "Get started" button from the pricing page, selecting the plan I want, it redirects me to my org page. Nowhere to pay for.
Then, when I try to login manually by navigating to the login page of my org, I get into an infinite loop of redirection. See:
(it's been doing so for at least 5 minutes now)
TBH, it doesn't make me want to upgrade anymore... I've been having problems for quite some times now, not being able to view my source files to check line by line, but only statistics. I thought that upgrading would give us the opportunity to discuss with real support, but even me wanted to pay fails, which is the peak :confused:
@edthrn thank you for filing the report. This looks like a bug and the team is investigating this.
In the interim, can you give me your email to forward to the team or you can email sales@codecov.io to upgrade the plan.
not being able to view my source files to check line by line, but only statistics
Can you elaborate on this? You should be able to view the file individual lines (from repo page) or by lines changed (per commit/pulls). cc @drazisil
You can email me at edouard [ at ] nibble [ dot ] ai
As per the issue of not being able to view the files, it worked well for a few weeks, but for more than a month now we've been having this error message on every file:
We thought it was related to the token used to communicate with our Github private repo, so we reset a new token, without any luck.
I try to login manually by navigating to the login page of my org, I get into an infinite loop of redirection
@edthrn the team investigated the issue. It looks like the problem is the the URL did not have a repo provider included.
The URL entered is codecov.io/login/nibbleai
- how did you get to this? Did you enter it manually? In any case, the reload shouldn't occur and we are fixing that. Thanks again for raising the issue 🙏
This issue has been open for 14 months now... quite a while.
@vinniefalco we kept it open to invite feedback from the community. It has been incredibly helpful as our team iterated with our new UI updates. But, indeed, the time is near and this issue will be closing soon because we are in the final inning of releasing the new UI to all pages. Additionally, we've added a dedicated feedback section in the new UI, which we invite all to visit and share your thoughts, proposals, and feedback on how we can improve. (it's located in the top-nav in the app)
@Codecovdesign please do preserve the escape hatch to the older design for as long as possible, until the kinks are worked out
we've added a dedicated feedback section in the new UI
This is great. I will let you all know (using my signature approach of excessive politeness) if the experience of my preferred workflow is better or worse. Well.... if its better I will probably be silent :)
@vinniefalco look forward to seeing your feedback there. Always room for improvement! 🙏
Thanks for dropping by! 👋
We've been iterating and updating the web app experience and would love your feedback about:
- What do you think about the new UI changes?
- What would you'd like to see improved?
- What are challenges you've experienced?
- How do you use the tool today? What parts do you use?
- If you don't use the web tool: why not?
- How could we better help your workflow?
- Any general thoughts you'd like to share!
We greatly appreciate your time and thoughts - looking forward to hearing from you ❤
Codecov team
This issue is intended to share and collect feedback about the tool. If you have support needs or questions, please see our support page.
Is there any way to view the interactive sunburst anymore? I was able to see it yesterday on the base page for my repo but it looks like the UI was just updated and it's no longer there...
Hey team! Love the new look and feel. :) However, it would be nice to get to the diff of the files impacted in the PR.
E.g see here:
How do i see the diff for the files, showing what the coverage changes are?
I actually have to go back to the main page, select the branch, and navigate to the file, to see this view:
It should be a link on the main PR page. Each file affected should be a link to the diff for that file.
any way to view the interactive sunburst anymore?
@sspenst the new UI does not have the sunburst on this release. Can you describe more about how you used it previously? or what task you were completing using it?
Previous feedback was that the sunburst offered at-a-glance ability to identify files that have low coverage. The problem was the usability of it was not ideal and forced the user to rely on the visual/clicking to identify the file. To solve this, for future iterations, we are looking at surfacing the files that have low coverage by 1) improved filtering in the table, 2) system to identify actionable files and surface to users (identified by mix of low coverage, line count / impact, and critical). With this direction, we hope to improve the UX search experience and also help identify files needing improvement without and user search required.
@RPM1984 thank you for your report!
Regarding pulls page table image you attached, this is very temporary. The table rows with the files will soon have an expand/collapse capability that will display the diff and specific lines affected. We are just finalizing the PR now to get it out. I'd love to hear your thoughts when it is released. Let us know! In the interim, here is how it will look:
any way to view the interactive sunburst anymore?
@sspenst the new UI does not have the sunburst on this release. Can you describe more about how you used it previously? or what task you were completing using it?
Previous feedback was that the sunburst offered at-a-glance ability to identify files that have low coverage. The problem was the usability of it was not ideal and forced the user to rely on the visual/clicking to identify the file. To solve this, for future iterations, we are looking at surfacing the files that have low coverage by 1) improved filtering in the table, 2) system to identify actionable files and surface to users (identified by mix of low coverage, line count / impact, and critical). With this direction, we hope to improve the UX search experience and also help identify files needing improvement without and user search required.
@Codecovdesign thanks for the response! The main use case for me was to identify the largest gaps in code coverage so I know which file to test next. With the new UI there is no way for me to know which specific file to test without digging into the folders.
The steps you mentioned sound like a good plan, especially point 2. Looking forward to these changes!
@RPM1984 thank you for your report!
Regarding pulls page table image you attached, this is very temporary. The table rows with the files will soon have an expand/collapse capability that will display the diff and specific lines affected. We are just finalizing the PR now to get it out. I'd love to hear your thoughts when it is released. Let us know! In the interim, here is how it will look:
Looks good, but it would still be nice to see the whole file (with the changes). Will we still have a link for that here, or will we just have the inline preview of just the diff?
The new interface is significantly more responsive; however, without the number of uncovered lines (and the ability to sort directories by it), the interface loses the bulk of its utility. Is there a way to get to the old interface?
Separately, there is a horizontal scrollbar that permanently obscures the source flag when a repo has long branch names:
Other feedback i would have is that we need the full page graphs back.
This is too small, to show the full picture:
Think about presentations and sharing things around. Bring back the old full page view with options to see per commit / day / month, please :)
without the number of uncovered lines (and the ability to sort directories by it)
@jsiirola thank for the report! Just to make sure I'm understanding, you're saying the line count of uncovered/covered by repo/file? Then sortable or filtered in the table? If yes, this is on the way. But if you have any more details about your workflow by line count, please let me know as this is in flight 🙏 EDIT: the dropdown issue is a known bug working on. curious, what browser are you using? thank you!
Thanks for dropping by! 👋
We've been iterating and updating the web app experience and would love your feedback about:
We greatly appreciate your time and thoughts - looking forward to hearing from you ❤
Codecov team
This issue is intended to share and collect feedback about the tool. If you have support needs or questions, please see our support page.