codecov / feedback

A place to discuss feedback about the pull request and web product experience.
34 stars 6 forks source link

Commits from the merge queue should be also shown in the main branch #216

Open rohan-at-sentry opened 8 months ago

rohan-at-sentry commented 8 months ago

Discussed in https://github.com/codecov/feedback/discussions/98

Originally posted by **justinchuby** October 13, 2023 We recently enabled codecov for the onnx/onnx repository. One of the things we discover is there is no "main" branch from the drop down: ![image](https://github.com/codecov/feedback/assets/11205048/7e72a29e-1873-484f-a91d-7ba5a8bf9e85) Turns out the commits from the merge queue branch `gh-readonly-queue/*` are the same commits in `main` (e.g. https://app.codecov.io/gh/onnx/onnx/commit/b61d2a8ab7a7e60eb386a387c73e449dd3461b3e), but codecov does not show these commits as part of the main branch. This causes the portal to show no "main" branch at all for coverage data, which can be inconvenient and confusing.
drazisil-codecov commented 8 months ago

@justinchuby,

Codecov is not aware that a branch exists until coverage is uploaded from it. Is it possible for you to have your CI upload coverage again after the PR is merged?

@rohan-at-sentry ,

Additionally, Codecov does not currently support commits existing on multiple branches, see https://github.com/codecov/feedback/discussions/178

justinchuby commented 8 months ago

Is it possible for you to have your CI upload coverage again after the PR is merged?

Do you have a recommended workflow for doing this?

drazisil-codecov commented 8 months ago

Is it possible for you to have your CI upload coverage again after the PR is merged?

Do you have a recommended workflow for doing this?

Depending on the CI workflow, you may be able to save the coverage report as an artifact somewhere. Then have a job that runs on main that: