search

codecov / feedback

A place to discuss feedback about the pull request and web product experience.
37 stars 7 forks source link

`!` pattern not working with `ignore:` #385

Open dabrahams opened 6 months ago

dabrahams commented 6 months ago

Describe the bug

ignore:
  - !Sources/

in codecov.yml produces:

yaml.constructor.ConstructorError: could not determine a constructor for the tag '!Sources/'
  in "<unicode string>", line 2, column 5:
      - !Sources/
        ^

Environment (please complete the following information):

To Reproduce

See https://github.com/hylo-lang/Swifty-LLVM/actions/runs/9132968118/job/25115449559?pr=73#step:17:56

You can clone the project and run it yourself if you want to reproduce.

Expected behavior All paths other than those beginning with Sources/ are ignored.

dabrahams commented 6 months ago

Never mind; it just needed to be quoted.

ignore:
  - '!Sources/'
drazisil-codecov commented 6 months ago

@rohan-at-sentry Related to this and Dave's other regex - docs related issues, https://github.com/codecov/shared/blob/f17719ac12d8e8bf60c7b51af5716b001ccdff0e/shared/validation/helpers.py#L223-L225 Seems well written. Possiby could be of help in re-writing the docs.

@dabrahams I'm going to re-open this so we address the confusion here in the docs.

dabrahams commented 6 months ago

The way y'all have responded to my filed issues is very gratifying and makes reporting them worthwhile. Keep up the great work!