codecov / feedback

A place to discuss feedback about the pull request and web product experience.
37 stars 7 forks source link

logout on self-hosted instance doesn't work (http method not allowed) #424

Closed derklaro closed 5 months ago

derklaro commented 5 months ago

Describe the bug When logged into a self-hosted CodeCov instance and clicking on your profile icon and then sign out, an error occurs because the GET method is not allowed for the logout route and the logout isn't working.

Environment (please complete the following information):

To Reproduce Steps to reproduce the behavior:

  1. Login to self-hosted instance of CodeCov
  2. Click on your profile icon
  3. Click on "Sign Out"
  4. See error page that the GET method is not allowed for /logout

Expected behavior The logout is working as expected, when reloading the site you're logged out and need to login again.

Screenshots

image

Additional context Clicking on the "POST" button on the error page actually triggers the logout, so there still is a way to get logged out 😄

spalmurray-codecov commented 5 months ago

@derklaro are you on the latest images? Will try to reproduce, but wanted to confirm first.

derklaro commented 5 months ago

I freshly cloned the example repo this morning, which uses the latest tag iirc

spalmurray-codecov commented 5 months ago

Thanks @derklaro - looking into this

spalmurray-codecov commented 5 months ago

Hey again @derklaro - once you pull down the latest images this should be fixed for you! 🙂