search

codecov / feedback

A place to discuss feedback about the pull request and web product experience.
38 stars 9 forks source link

Bug Report: Missing Diff metric on Commit and Pull overview #433

Open twom opened 5 months ago

twom commented 5 months ago

Describe the bug Previously we could observe a coverage diff on the commit and pull request view in codecov. These metrics helped the team to get a glance over the improvements the PR or commits had.

This metric has disappeared from the views in codecov

Environment (please complete the following information):

To Reproduce Steps to reproduce the behavior:

  1. Go to a project in codecov
  2. Click on Commits or Pulls
  3. View the table
  4. No diff column present

Expected behavior As before, we would expect a diff columnt to be present

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Seeing coverage diffs helps the team to quickly review the impact of specific commits or PRs.

codecovdesign commented 5 months ago

Thank you @twom for opening. I'm investigating this and have a question: are you able to see patch %? if not could you screenshot the UI? Just want to confirm that is working as intended. I suspect you are referring to project coverage missing and change (+/-) - is this right?

twom commented 5 months ago

Thank you @codecovdesign !

We indeed see patch coverage (which is actually our most important metric currently, so we can ensure the quality of the change is high).

I noticed first that the total coverage diff got removed from the Commits tab, and this week from the Pulls tab. It is a metric mainly used by the engineering managers to have an overview of progress in a quick glance.

Partial screenshots from the Commits and Pulls tab:

image image