4.4.1 => 4.5 GH action upgrade produces "token not found"

[dabrahams]

Describe the bug I can't upgrade to codecov-action v4.5 because it complains:

"Error: Codecov token not found. Please provide Codecov token with -t flag."

The token is clearly registered in my repository secrets, and works with v 4.4.1 of codecov-action.

Environment (please complete the following information):

• Browser Arc
• System: macos-latest GitHub actions runner

To Reproduce You can fork the repository for yourself to reproduce if you really want to. Probably best just to look at the failure here, though: https://github.com/hylo-lang/Lotsawa/actions/runs/9946723359/job/27478697815#step:4:34

[drazisil-codecov]

Hi @dabrahams ,

Can you enable verbose on the action so we can check if it's seeing the env at all, or if it's possibly blank, like this issue? https://github.com/actions/runner/issues/2414

[charlesrocket]

Same here, worked fine just recently, token in the repo, prev builds with hardcoded token are green.

[charlesrocket]

@drazisil-codecov token in the action is missing in my pipe tho token is in the codecov task https://github.com/charlesrocket/pixelmosh/blob/45049967ef4cf362e180dd0fbf408cfbb167df8d/.github/workflows/ci.yml#L93

2024-08-01T21:28:11.8205255Z ##[group]Run codecov/codecov-action@v4
2024-08-01T21:28:11.8205668Z with:
2024-08-01T21:28:11.8205968Z   files: lcov.info
2024-08-01T21:28:11.8206404Z   fail_ci_if_error: true
2 . . .

https://github.com/charlesrocket/pixelmosh/actions/runs/10198774739/job/28238069224#step:7:1

Replaced the token, just in case—same results.

[thomasrockhu-codecov]

@charlesrocket strange, can you try doing

with:
  files: lcon.info
  fail_ci_if_error: true
env:
  CODECOV_TOKEN: ${{ secrets.CODECOV_TOKNE }}

[charlesrocket]

@thomasrockhu-codecov it works on the test branch now, original non-env config as well https://github.com/charlesrocket/pixelmosh/actions/runs/10226223229/job/28296217820#step:6:1 (both cases are on this branch). poisoned cache?

[thomasrockhu-codecov]

@charlesrocket honestly I'm not too sure. I've been trying to hunt down the reason behind having it as an argument vs as an env variable, as it doesn't seem consistent when it works in one versus the other.

If you have any insight into why that might be or if your repository has some special settings, it would be greatly appreciated. Else, I'll close out next week if this is a working solution for you.

[thomasrockhu-codecov]

@charlesrocket oh! was this a dependabot run? Perhaps you need to add the secret to the Dependabot secrets. It should be in the section next to the repository secrets in the sidebar

[charlesrocket]

@thomasrockhu-codecov sweet, it works now. thank you!