search

codecov / feedback

A place to discuss feedback about the pull request and web product experience.
38 stars 9 forks source link

`adjust_base` Does not seem to be correctly calculating. #463

Closed drazisil-codecov closed 1 month ago

drazisil-codecov commented 3 months ago

Here is another case where the report seems to calculate something strange: https://github.com/xmldom/xmldom/pull/698#issuecomment-2254651688

Image

Not sure how it is calculated, but when 6 lines and one branch are being removed, they can of course also no longer be hit?

Or am I misunderstanding something?

I even added/extended tests in that commit.

Originally posted by @karfau in #8

@karfau I agree with you, after taking a look. @rohan-at-sentry is this a bug, or some part of the system that needs better docs?

https://app.codecov.io/gh/xmldom/xmldom/pull/698?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=xmldom is the only changed file, and it shouldn't fail project, given it's 100% covered.

Originally posted by @drazisil-codecov in #8

eliatcodecov commented 3 months ago

Difficult to determine if this is potentially a systemic issue with adjust_base or just unique to this repo somehow. Work would be to audit adjust_base and ensure it's working as expect.