search

codecov / feedback

A place to discuss feedback about the pull request and web product experience.
35 stars 6 forks source link

Duplicated codecov checks #474

Open A5rocks opened 2 months ago

A5rocks commented 2 months ago

Reopening https://github.com/codecov/codecov-action/issues/1022, @thomasrockhu.

In https://github.com/python-trio/trio/pull/3040 for example, you can see a failed check and a successful check for the PR. If you check the commit specifically, there's duplicated versions of the checks but at least they are consistent.

Screenshot:

Image

https://github.com/python-trio/trio/pull/3029 is another that comes from a fork rather than from the same repository (hence doesn't duplicate regular github actions checks)

Edit: just note that we use codecov action v3 so this might be fixed? Though codecov action v4 led to weird coverage drops that were still there so we haven't switched.

thomasrockhu-codecov commented 2 months ago

@A5rocks moving this to our feedback repo

thomasrockhu-codecov commented 2 months ago

@drazisil-codecov do you mind taking a look why we are sending duplicate status checks?

drazisil-codecov commented 2 months ago

@thomasrockhu-codecov One is a check, the other is a status.

I suspect @A5rocks is seeing this bug https://github.com/codecov/engineering-team/issues/1967

A5rocks commented 2 months ago

That seems very likely! https://github.com/python-trio/trio/pull/3051 is another PR that hit this just in case it helps.