search

codecov / feedback

A place to discuss feedback about the pull request and web product experience.
37 stars 7 forks source link

C++ coverage erroneously contains the function header #482

Closed AMS21 closed 2 months ago

AMS21 commented 3 months ago

Describe the bug C++ coverage erroneously contains the function header and shows it as missed.

Environment (please complete the following information):

To Reproduce Steps to reproduce the behavior:

  1. Coverage is automatically generated and uploaded by GitHub actions with this workflow
  2. Check the coverage info on the website here
  3. Notice the "missed" line which just contains the function header.

Expected behavior Functions headers should be ignored as they cannot be hit.

Screenshots

Image

Additional context Judging from the timeline this started somewhere between July 08 and July 15.

drazisil-codecov commented 3 months ago

Hi @AMS21 ,

Your coberture report says that only line 20 exists, which is why we show it as covered. The gcov reports though show both lines 17 and 20 as code.

Did you update your test runner config or anything recently? I suspect you were only uploading cobertura XML before.

AMS21 commented 2 months ago

Hi, sorry for the late response.

No honestly I haven't updated the test runner config in ages. The only commits in that time frame are Dependabot updates for the GitHub Actions or other unrelated things.

drazisil-codecov commented 2 months ago

Hmm.

Can you try adding plugin: noop to the with: section of your action config and see if that clears it up any?

AMS21 commented 2 months ago

Hmm.

Can you try adding plugin: noop to the with: section of your action config and see if that clears it up any?

Yes, that fixed the problem coverage is back to what it was before. Thanks for the quick (on your part) help.