search

codecov / feedback

A place to discuss feedback about the pull request and web product experience.
38 stars 9 forks source link

[CLI] "upload process" command should cancel any remaining tasks in the chain if one fails #486

Closed drazisil-codecov closed 2 months ago

drazisil-codecov commented 3 months ago

The "upload process" command should cancel any remaining tasks in the chain if one fails.

"Create commit" "Create Report" "Do Upload"

Have to succeed in older and if one errors then there is no chance that the others will correctly succeed (even if they think they did)

giovanni-guidini commented 2 months ago

Are there examples of this not being the case?

Because looking at the code, the first 2 commands are called with fail_on_error=True (see here and here). And following along the code it ends up exiting the program in case of error (see here)

drazisil-codecov commented 2 months ago

@giovanni-guidini I thought I saw one, but if the code says we don, then I'll close unless it happens again.