codecov / feedback

A place to discuss feedback about the pull request and web product experience.
37 stars 7 forks source link

Bug Report: This repo has been deactivated, but suggested fix does *not* work! (there is an infinite loop) #518

Closed danieltrick closed 2 months ago

danieltrick commented 2 months ago

Describe the bug When trying to access my Codecov proejct, I get error message:

This repo has been deactivated To reactivate the repo go to or upload a coverage report and it will be automatically re-activated.

Why ?!

Also, uploading a new coverage report (as suggested by the error message!) does not work either 😳

debug - 2024-09-20 11:56:29,715 -- Sending upload request to Codecov
info - 2024-09-20 11:56:30,101 -- Process Upload complete
debug - 2024-09-20 11:56:30,101 -- Upload result --- {"result": "RequestResult(error=RequestError(code='HTTP Error 400', params={}, description='[\"This repository has been deactivated. To resume uploading to it, please activate the repository in the codecov UI: https://app.codecov.io/github/danieltrick/tss2-fapi-rs/settings\"]'), warnings=[], status_code=400, text='[\"This repository has been deactivated. To resume uploading to it, please activate the repository in the codecov UI: https://app.codecov.io/github/danieltrick/tss2-fapi-rs/settings\"]')"}
error - 2024-09-20 11:56:30,101 -- Upload failed: ["This repository has been deactivated. To resume uploading to it, please activate the repository in the codecov UI: https://app.codecov.io/github/danieltrick/tss2-fapi-rs/settings"]

So we have an infinte loop here:

Hmm, yeah... 🤯

And why has the account been deactivated in the first place?

Upload has been working until very recently, so the CI pipeline is working correctly and the Token is set up correctly!

Here is an example from previous log:

debug - 2024-09-15 21:00:14,127 -- Sending upload request to Codecov
info - 2024-09-15 21:00:14,354 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/danieltrick/tss2-fapi-rs/commit/52e2afaa6e9289454e17ea16571b7fe18f5923f9
debug - 2024-09-15 21:00:14,354 -- Upload request to Codecov complete. ---

Environment (please complete the following information):

To Reproduce Go to: https://app.codecov.io/github/danieltrick/tss2-fapi-rs

Expected behavior I should be able to access my Codecov project and I should be able to upload coverage reports!

Screenshots Image

danieltrick commented 2 months ago

Just found out that even though all tabs in Codecov show "This repo has been deactivated", it turns out that the "Configuration" tab actually still works and, deep buried in the configuration settings, there was an "Activate" button.

So, the problem is solved for now, but the error message still is very confusing and misleading.

Error message should probably read:

This repo has been deactivated FOR REASON XYZ. In order to reactivate it, go to the "Configuration" tab and find the "Activate" button.

Also still doesn't explain why the project has been deactivated in the first place.

drazisil-codecov commented 2 months ago

Seems very recent, though I can't see what caused it to deactivate. Can you confirm it was working fine prior to yesterday?

drazisil-codecov commented 2 months ago

Error message should be:

This repo has been deactivated FOR REASON XYZ. In order to reactivate it, go to the "Configuration" tab – note: unlike all the other tabs the "Configuration" tab still is accessible – and > > find the "Activate" button.

@codecovdesign see feedback.

danieltrick commented 2 months ago

Seems very recent, though I can't see what caused it to deactivate. Can you confirm it was working fine prior to yesterday?

Yes, I can see from the GitHub Actions logs that it started failing some time around yesterday.

(I did not change anything about the CI pipeline that performs the coverage analysis and uploads the result in that timeframe)

drazisil-codecov commented 2 months ago

It looks like at 2024-09-19T09:24:01.037727423Z we got a web hook from GitHub saying the public visibility of the repo was changed to public. I believe that toggles the repo to 'deactivated' on the Codecov side so if it was a mistake, no one can see the repo on Codecov (since it's now public), until a member activates it again. Does that sound like what may have happened?

dEajL3kA commented 2 months ago

Yeah, repo was changed to public indeed. Didn't expect this would affect/break Codecov upload, though 😅

I believe that toggles the repo to 'deactivated' on the Codecov side so if it was a mistake, no one can see the repo on Codecov (since it's now public), until a member activates it again.

Makes sense. But it would be great if that was actually communicated to the user. Instead, I suddenly saw that Codecov uploads fail with a hint that I should login to the UI to reactivate the project – which in turn told me that I need to upload a new coverage report to reactivate.

drazisil-codecov commented 2 months ago

Yeah, repo was changed to public indeed. Didn't expect this would affect/break Codecov upload, though 😅

I believe that toggles the repo to 'deactivated' on the Codecov side so if it was a mistake, no one can see the repo on Codecov (since it's now public), until a member activates it again.

Makes sense. But it would be great if that was actually communicated to the user. Instead, I suddenly saw that Codecov uploads fail with a hint that I should login to the UI to reactivate the project – which in turn told me that I need to upload a new coverage report to reactivate.

@rohan-at-sentry, @codecovdesign Can we find a better way to convey this to the customer?

drazisil-codecov commented 2 months ago

(In the product team's defense, I have a slight advantage in having been with Codecov a lot longer then any of them and being able to remember very rare things when I go though the logs and code that they didn't even know existed 😅 We'll get everything correctly documented and surfaced someday , it's a work in progress)