search

codecov / feedback

A place to discuss feedback about the pull request and web product experience.
37 stars 7 forks source link

Codecov always attempts to send a "slack" notification. Slack should be set to "false" in the codecov default config. #528

Open vlad-ko opened 1 month ago

vlad-ko commented 1 month ago

Describe the bug

A slack integration is enabled "by default" in the codecov config.

Image

As we can see in the screenshot above the slack_app: true value is in the yaml file. Even though I don't actually have this set in the repo yaml. https://github.com/vlad-ko/laravel-stripe-app-gh/blob/main/codecov.yml

(No "slack" key defined at all).

This causes codecov to attempt to send a notification to slack for every single customer (and every single notification). We also observe this in the support requests when looking at the set of the "attempted notifications", we always seem to try to send a slack notification, even if the customer does not have it configured.

eliatcodecov commented 2 weeks ago

The ask is to update the default yaml slack_app configuration to false.

eliatcodecov commented 2 weeks ago

I think we need to investigate the ramifications of setting this slack_app setting in the yaml to false by default. will it break usage for current users of the slack integration to do so? If so, we need to re-discuss and find a better plan.