codecov / feedback

A place to discuss feedback about the pull request and web product experience.
37 stars 7 forks source link

Keep getting the "Please install the codecov app" warning although the app is installed #537

Closed gulien closed 1 month ago

gulien commented 1 month ago

Describe the bug Every time a PR is created in one of the gotenberg organization repository with codecov integration (via GitHub Actions), codecov tells us to install the codecov app.

Problem is that the codecov app is in fact installed 🤔

Environment (please complete the following information):

GitHub Actions with codecov/codecov-action@v4 (for instance here).

To Reproduce Create a PR in the gotenberg/gotenberg repository.

Expected behavior No warning message asking us to install the codecov app 😄

Screenshots Image


Image

Additional context It's just a warning message, it seems to work as expected otherwise.

nikosatwork commented 1 month ago

Perhaps you need some basic codecov.yml file (it can go under the .github folder)

drazisil-codecov commented 1 month ago

@gulien

The app is required for private repos and stringly recommended for public ones. It allows Codecov to use a seperate GitHub API rate limit for your org. Otherwise, public activities will work, ONLY as long as the rate limit pool that Codecov shares with all public customers is not used iup.

gulien commented 1 month ago

Hey @drazisil-codecov 👋 as mentioned, it is already installed 😄

@nikosatwork Last time I checked, the codecov.yml file was not mandatory for non-advanced usage 🤔

drazisil-codecov commented 1 month ago

Caffeine hadn't kicked in yet, sorry. Let me investigate.

drazisil-codecov commented 1 month ago

The database doesn't seem to see the app is installed. Can you double-check https://github.com/apps/codecov and share the number on the end of the URL for the config page?

gulien commented 1 month ago

No problem 😄 Here is the number: 51807717

drazisil-codecov commented 1 month ago

I have zero records on that, and I checked in a few places in the database. Can I ask you to reinstall it? 🙏

gulien commented 1 month ago

It has been reinstalled, and the new number is 55996949 😄

drazisil-codecov commented 1 month ago

Looks much better! Please tell me if you still get the message on new PRs.

gulien commented 1 month ago

Seems good now: https://github.com/gotenberg/gotenberg-php/pull/51

Thanks 🎉