codecov / feedback

A place to discuss feedback about the pull request and web product experience.
37 stars 7 forks source link

[Self-hosted] Auto-activate members doesn't work in latest/24.10.1 #554

Open nikosatwork opened 4 weeks ago

nikosatwork commented 4 weeks ago

Describe the bug

Users will automatically be assigned a Codecov seat if they 1) author a pull request on a private repo, or 2) log in to a private repo and if there are seats available in the subscription.

Note: We have 2 active users of 500 available seats

Possibly related to https://github.com/codecov/feedback/issues/536 and https://github.com/codecov/feedback/issues/523

Environment (please complete the following information):

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'User Settings'
  2. Set 'Activation Status' to false / uncheck
  3. Go to a private repository
  4. Get "Unauthorized. Activation is required to view this repo, please click here to activate your account."

Expected behavior

Activate the seat and land on a working repo page

Screenshots

Image

Image

Additional context

This is urgent as we have been trying to resolve this "mutating" issue since https://github.com/codecov/feedback/issues/523

Thank you 🙏

nikosatwork commented 4 weeks ago

The above workflow is true if guest_access: true

If guest_access: false then we can't even login at codecov home page as it keeps looping to itself

Will start downgrading the codecov version to try to find the regression

nikosatwork commented 4 weeks ago
eliatcodecov commented 3 weeks ago

Likely related to #536 and this stems from issues with guest access breaking auto activate. Assigning to @RulaKhaled as this ticket and #536 likely share the same root cause.

nikosatwork commented 1 week ago

I wanted to add that when a new user signs in with 'Login via GitHub Enterprise', they do not get their seat auto-activated either.

nikosatwork commented 22 hours ago

Hi team. Is there an update on this issue? Thank you 🙏

cc @drazisil-codecov @eliatcodecov @RulaKhaled

RulaKhaled commented 20 hours ago

Hey @nikosatwork, I've divided this work into two key tasks:

RulaKhaled commented 17 hours ago

@nikosatwork Quick update: This PR should fix auto-activation. Once both PRs are merged, I'll check in with you to confirm it works as expected

nikosatwork commented 16 hours ago

Awesome! ❤