[Self-hosted] [Regression] 404 page has no login options

codecov / feedback

A place to discuss feedback about the pull request and web product experience.

37 stars 7 forks source link

[Self-hosted] [Regression] 404 page has no login options #555

Closed nikosatwork closed 1 week ago

nikosatwork commented 4 weeks ago

Describe the bug

When anyone landing on an private repo page in codecov, and are not logged in or are not account members, they get a 404 page. This page does not have the login options at the top, so users are stuck.

Environment (please complete the following information):

Browser: Any
System: local machine

Version: 24.10.1

To Reproduce Steps to reproduce the behavior:

Make sure you are not logged in to Codecov or this is a new user not registed in Codecov db yet
Go to a repo page within Codecov
Get a 404 error, with no way to login

Expected behavior Get a nice login page or show & point to use the Login button in the top bar

Screenshots

Additional context

nikosatwork commented 4 weeks ago

In 24.8.1 it redirects you to home screen

eliatcodecov commented 3 weeks ago

Still feels somewhat related to #536 and #554. Will assign to @RulaKhaled in the event these share a similar root cause.

RulaKhaled commented 1 week ago

@eliatcodecov It's not really a bug, the login button in the top banner is always visible

So far, this is the expected behavior in the app; it’s not specific to self-hosted instances. Is there a particular design we want to implement here? Looping in @Adal3n3 and @codecov/design for further input

nikosatwork commented 1 week ago

In self-hosted v24.10.1, if you logout and land on a private repository within Codecov, then you get the 404 with no navigational bar at the top.

Example:

nikosatwork commented 1 week ago

From Network inspection, https://codecov.self-hosted.com/internal/user call returns:

"detail": "Authentication credentials were not provided."

RulaKhaled commented 1 week ago

Got it, thanks for the quick follow-up. I will be investigating this.

RulaKhaled commented 1 week ago

@nikosatwork the latest version is now Release 24.11.1 can you still see this error?

nikosatwork commented 1 week ago

Thank you @RulaKhaled - I can confirm this is fixed in 24.11.1, and the Login button gets you to the home screen where you can login.

Ideally users should be able to login & land on the page they were visiting in the first place.

Scenario:

The link https://codecov.self-hosted.com/ghe/org/private-repo is shared on slack or in a pull request/codecov comments
A new user (someone that has not signed in before to codecov.self-hosted) clicks on the link
Codecov undertands that this is a private repo they are visiting & present a page with a 'Login via GitHub Enterprise' button in the center of the page, instead of the 404 page
User hits 'Login via GitHub Enterprise' and lands on the original link https://codecov.self-hosted.com/ghe/org/private-repo (not on org screen https://codecov.self-hosted.com/ghe/org)

RulaKhaled commented 1 week ago

I agree, your suggestion makes sense! fwiw the 404 page plays a security role it's designed to prevent unauthorized individuals from gaining any hints about the existence of private repositories, we effectively avoid confirming whether a repository exists or not to anyone who isn't authenticated. With that in mind, our goal is to balance security and usability so i will definitely raise this with product team to unify this desired experience in both cloud and self hosted.

I will close this issue as resolved in the latest version and link the new issue for the desired flow once it's ready :)