Open MetRonnie opened 4 weeks ago
Sorry for the delay in responding. @MetRonnie It looks like the linked issue is no longer inconsistent. I suspect that the problem was related to the coverage report still being processed when accessing the webpage. We are working on a longer term solution in this issue: https://github.com/codecov/engineering-team/issues/2702
Describe the bug
When a GitHub Actions workflow runs on the
pull_request
event,actions/checkout
by default does not check out the pull request branch itself, but merges it into the base branch and checks out this merge commit.This means that the reported coverage is for this merge commit, but the Codecov website does not account for this. When you view the coverage for a PR on the Codecov website, it shows the files as they are in the PR branch, meaning the coverage lines are incorrect (when there have been other changes to the same files committed to the base branch).
Environment (please complete the following information):
To Reproduce Steps to reproduce the behavior:
Expected behavior I guess the only solution is for the Codecov website to display the same internal merge commit that
actions/checkout
checked out, rather than the head commit of the PRScreenshots
Here the coverage lines start to go wrong at L880 - executable lines are shown as unexecutable and vice versa!
Here is the commit graph. The highlighted merge commit added some lines at L880 to the same file.
Here is that merge commit.
Additional context Here is the GitHub Actions workflow for this repo: https://github.com/cylc/cylc-flow/blob/2f495817a19f09f4ed12aa6a00162a2923b291eb/.github/workflows/test_fast.yml