codecov / feedback

A place to discuss feedback about the pull request and web product experience.
34 stars 6 forks source link

[Privacy] Hide private GitHub repo names in Codecov public profile #66

Closed cbismuth closed 4 months ago

cbismuth commented 1 year ago

Dear Codecov Team,

Private GitHub repo names are listed in Codecov public profile.

Is there a way to re-sync this list?

https://app.codecov.io/gh/cbismuth https://github.com/cbismuth?tab=repositories

Thanks, Christophe

rohan-at-sentry commented 1 year ago

Hey @cbismuth

Codecov is showing the following repos

Do you know if these were explicitly marked as private? All I can see on codecov is that these are public and inactive, and I don't see those in your github.

Were these deleted on your end?

cbismuth commented 1 year ago

@rohan-at-sentry, thanks for your reply, these repositories were public before I made them private on GitHub.

rohan-at-sentry commented 1 year ago

Thanks @cbismuth - I'm also assuming you tried to resynch manually from the UI - see screenshot Can you confirm?

image

cbismuth commented 1 year ago

Yes @rohan-at-sentry, I tried once again just now, then signed out and in again, but still facing this issue.

rohan-at-sentry commented 12 months ago

@cbismuth apologies for the delay in responding. Yeah this looks like a bug. I've assigned it as such, will pull it into a sprint soon and keep you updated

cbismuth commented 12 months ago

Thanks @rohan-at-sentry.

cnlangzi commented 6 months ago

got similar issue. could we have an option to hide repos on codecov public page? eg https://app.codecov.io/gh/yaitoo We only have 2 public repos now. is it possible to hide other 5 repos?

cnlangzi commented 6 months ago

tried multiple solutions, but all of them don't work

rohan-at-sentry commented 6 months ago

Thanks for bubbling this back up @cnlangzi - sorry that this hasn't seen any movement for a while. I can reprioritize this week and update back here

ajay-sentry commented 5 months ago

@cnlangzi @cbismuth After doing some digging, we've seen that the list of repositories coming back from github don't include a number of repositories; including ones mentioned above that we wish to turn private.

Could you please confirm when going to Github profile -> Settings -> Applications -> Installed Github Apps (screenshots attached), that "All Repositories" is checked? From there if you could try re-syncing the repos and confirm that the repositories privacy status is in the correct state, that would be incredibly helpful.

If that proves to not be the fix, we can continue to investigate. Thank you for your patience!

Screenshot 2024-04-09 at 11 56 22 AM Screenshot 2024-04-09 at 11 55 45 AM

Screenshot 2024-04-09 at 2 14 41 PM

cnlangzi commented 5 months ago

@ajay-sentry good job. it works now if repository is private and granted. but it still not work if a repository is deleted on github or not granted. do you think it is better:

ajay-sentry commented 5 months ago

@cnlangzi I'm glad we were able to make some progress here :) And yes that's a great call out and something I noticed as well in my testing. I've surfaced this with the team and will report back after we discuss a path forward

drazisil-codecov commented 5 months ago

@ajay-sentry That's this code, for reference https://github.com/codecov/codecov-api/blob/bce1ddd11ddd17ea61e027082abd0303c500f8f4/webhook_handlers/views/github.py#L187-L197

ajay-sentry commented 4 months ago

Hey @cnlangzi, just an update to close the loop here. We have discussed as a team and have found that there are a lot of areas of improvement we can be making for this particular task, and have created a new epic to track here if you would like to stay informed throughout! For now, we would like to close this ticket as "complete" since we have a workaround, but we know there is much to be done here and will try and prioritize in the near future.

https://github.com/codecov/engineering-team/issues/1633