search

codecov / python-standard

Codecov coverage standard for Python
MIT License
14 stars 21 forks source link

GitHub Action: Upgrade to current Python 3.11 #30

Closed cclauss closed 1 year ago

cclauss commented 1 year ago

It is faster... https://docs.python.org/3.11/whatsnew/3.11.html

Python 3.11 is between 10-60% faster than Python 3.10. On average, we measured a 1.25x speedup on the standard benchmark suite.

codecov[bot] commented 1 year ago

Codecov Report

Merging #30 (6305c24) into master (54b18d7) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           2        2           
  Lines          14       14           
=======================================
  Hits           12       12           
  Misses          2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

cclauss commented 1 year ago

https://devguide.python.org/versions

thomasrockhu-codecov commented 1 year ago

@cclauss why the move to only 3.9?

cclauss commented 1 year ago

Click the ❌ next to the 3 test runs above to see the results. The tests fail when I upgrade but also when I run all versions of Python. Do you have any hints on how to make the tests pass consistently?

Waiting 60 seconds for report to upload before pinging API...
Pinging Codecov's API..
Ensuring coverage percentage is accurate...
Whoops, something is wrong D: Codecov did not return the correct coverage percentage.
    Coverage percentage should be  but Codecov returned 85.71
Error: Process completed with exit code 1.
cclauss commented 1 year ago

Actually, I see that the tests seem to always fail on pull requests but they seem to pass when you merge those pull requests to master.

Turning back on multiple Pythons...

cclauss commented 1 year ago

My bet is that these tests will all fail but when you merge the PR, they will all pass.

thomasrockhu-codecov commented 1 year ago

@cclauss yeah... it's a failure with vars not being available to forks. I don't really have a good solution for this yet without hard-coding it, which feels a little dirty.

cclauss commented 1 year ago

My bet is that when you merge the PR, all tests will pass.

thomasrockhu commented 1 year ago

@cclauss agreed