search

codecov / self-hosted

Example of how to setup Codecov with docker compose
Other
409 stars 32 forks source link

insert RUN_ENV envrionment for worker #14

Closed LeoQuote closed 10 months ago

LeoQuote commented 10 months ago

for enterprise instance, this environment should set to RUN_ENV

https://github.com/codecov/worker/blob/5d91d084eb8c80fd1f26c685d5076df9b5d8b80f/helpers/environment.py#L44-L59

koltyakov commented 10 months ago

Out of the interest, what's the difference between Enterprise and Production?

LeoQuote commented 10 months ago

Out of the interest, what's the difference between Enterprise and Production?

I don’t know exactly how different they are, you can check the code if you want

fmdoe commented 10 months ago

Out of the interest, what's the difference between Enterprise and Production?

Enterprise uses the custom url from the config in PR comments and notifications: https://github.com/codecov/worker/blob/4ce002549166bfbbede1931db9e724ca4011457a/services/urls.py#L47-L55

koltyakov commented 10 months ago

So it sounds that RUN_ENV=ENTERPRISE is a must have for self-hosted for now.

LeoQuote commented 10 months ago

@koltyakov exactly, if this is unset, comment posted by codecov bot would have link starting with app.codecov.io instead of your enterprise instance

trent-codecov commented 10 months ago

Your assessment is correct. Thanks for the fix. We use RUN_ENV=ENTERPRISE to do a couple of things:

  1. don't check for upload limitations
  2. use your base url rather than app.codecov.io
  3. probably other things I am forgetting 😄