Closed giovanni-guidini closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.03%. Comparing base (
901c335
) to head (8aef1bf
). Report is 3 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 438 438
Lines 36470 36477 +7
=======================================
+ Hits 35752 35759 +7
Misses 718 718
Flag | Coverage Δ | |
---|---|---|
integration | 98.03% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 98.03% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.90% <100.00%> (ø) |
|
OutsideTasks | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
Files with missing lines | Coverage Δ | |
---|---|---|
services/activation.py | 93.10% <100.00%> (ø) |
|
services/bundle_analysis/notify/__init__.py | 100.00% <100.00%> (ø) |
|
...rvices/bundle_analysis/notify/contexts/__init__.py | 99.10% <100.00%> (ø) |
|
...ervices/bundle_analysis/notify/contexts/comment.py | 98.88% <100.00%> (ø) |
|
...s/bundle_analysis/notify/contexts/commit_status.py | 100.00% <100.00%> (ø) |
|
...ysis/notify/contexts/tests/test_comment_context.py | 100.00% <100.00%> (ø) |
|
...otify/contexts/tests/test_commit_status_context.py | 100.00% <100.00%> (ø) |
|
services/bundle_analysis/notify/helpers.py | 100.00% <100.00%> (ø) |
|
...dle_analysis/notify/messages/tests/test_comment.py | 100.00% <100.00%> (ø) |
|
...alysis/notify/messages/tests/test_commit_status.py | 100.00% <100.00%> (ø) |
|
... and 2 more |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.03%. Comparing base (
901c335
) to head (8aef1bf
). Report is 3 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 438 438
Lines 36470 36477 +7
=======================================
+ Hits 35752 35759 +7
Misses 718 718
Flag | Coverage Δ | |
---|---|---|
integration | 98.03% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 98.03% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.90% <100.00%> (ø) |
|
OutsideTasks | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
Files with missing lines | Coverage Δ | |
---|---|---|
services/activation.py | 93.10% <100.00%> (ø) |
|
services/bundle_analysis/notify/__init__.py | 100.00% <100.00%> (ø) |
|
...rvices/bundle_analysis/notify/contexts/__init__.py | 99.10% <100.00%> (ø) |
|
...ervices/bundle_analysis/notify/contexts/comment.py | 98.88% <100.00%> (ø) |
|
...s/bundle_analysis/notify/contexts/commit_status.py | 100.00% <100.00%> (ø) |
|
...ysis/notify/contexts/tests/test_comment_context.py | 100.00% <100.00%> (ø) |
|
...otify/contexts/tests/test_commit_status_context.py | 100.00% <100.00%> (ø) |
|
services/bundle_analysis/notify/helpers.py | 100.00% <100.00%> (ø) |
|
...dle_analysis/notify/messages/tests/test_comment.py | 100.00% <100.00%> (ø) |
|
...alysis/notify/messages/tests/test_commit_status.py | 100.00% <100.00%> (ø) |
|
... and 2 more |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.03%. Comparing base (
901c335
) to head (8aef1bf
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #777 +/- ##
=======================================
Coverage 98.03% 98.03%
=======================================
Files 438 438
Lines 36470 36477 +7
=======================================
+ Hits 35752 35759 +7
Misses 718 718
Flag | Coverage Δ | |
---|---|---|
integration | 98.03% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 98.03% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.90% <100.00%> (ø) |
|
OutsideTasks | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
Files | Coverage Δ | |
---|---|---|
services/activation.py | 93.10% <100.00%> (ø) |
|
services/bundle_analysis/notify/__init__.py | 100.00% <100.00%> (ø) |
|
...rvices/bundle_analysis/notify/contexts/__init__.py | 99.10% <100.00%> (ø) |
|
...ervices/bundle_analysis/notify/contexts/comment.py | 98.88% <100.00%> (ø) |
|
...s/bundle_analysis/notify/contexts/commit_status.py | 100.00% <100.00%> (ø) |
|
...ysis/notify/contexts/tests/test_comment_context.py | 100.00% <100.00%> (ø) |
|
...otify/contexts/tests/test_commit_status_context.py | 100.00% <100.00%> (ø) |
|
services/bundle_analysis/notify/helpers.py | 100.00% <100.00%> (ø) |
|
...dle_analysis/notify/messages/tests/test_comment.py | 100.00% <100.00%> (ø) |
|
...alysis/notify/messages/tests/test_commit_status.py | 100.00% <100.00%> (ø) |
|
... and 2 more |
This was not the main goal I had, but these errors were really distracting, so fixing some type errors in BA notifiers.
One side-effect is that when loading the user_config we are now expecting the comment config to be
bool | dict
(notNone
). This is in fact the case because we have default config in place, but the tests didn't know that. Now they do.I might have also caught a bug in the user activation in terms of the func args.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.