Open matt-codecov opened 1 week ago
codecov[bot]
commented
1 week ago Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 98.00%. Comparing base (
48ce427) to head (1cd2e55).
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| tasks/base.py | 77.77% | 4 Missing :warning: |
codecov-notifications[bot]
commented
1 week ago Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| tasks/base.py | 77.77% | 4 Missing :warning: |
@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 98.01% 98.00% -0.01%
==========================================
Files 443 443
Lines 36615 36637 +22
==========================================
+ Hits 35887 35905 +18
- Misses 728 732 +4 | Flag | Coverage Δ | |
|---|---|---|
| integration | 98.00% <82.60%> (-0.01%) |
:arrow_down: |
| unit | 98.00% <82.60%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| NonTestCode | 95.85% <82.60%> (-0.03%) |
:arrow_down: |
| OutsideTasks | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| helpers/checkpoint_logger/flows.py | 100.00% <100.00%> (ø) |
|
| tasks/base.py | 95.04% <77.77%> (-1.69%) |
:arrow_down: |
codecov-qa[bot]
commented
1 week ago Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 98.00%. Comparing base (
48ce427) to head (1cd2e55).
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| tasks/base.py | 77.77% | 4 Missing :warning: |
@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 98.01% 98.00% -0.01%
==========================================
Files 443 443
Lines 36615 36637 +22
==========================================
+ Hits 35887 35905 +18
- Misses 728 732 +4 | Flag | Coverage Δ | |
|---|---|---|
| integration | 98.00% <82.60%> (-0.01%) |
:arrow_down: |
| unit | 98.00% <82.60%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| NonTestCode | 95.85% <82.60%> (-0.03%) |
:arrow_down: |
| OutsideTasks | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
| Files with missing lines | Coverage Δ | |
|---|---|---|
| helpers/checkpoint_logger/flows.py | 100.00% <100.00%> (ø) |
|
| tasks/base.py | 95.04% <77.77%> (-1.69%) |
:arrow_down: |
codecov-public-qa[bot]
commented
1 week ago Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
Project coverage is 98.00%. Comparing base (
48ce427) to head (1cd2e55).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 98.01% 98.00% -0.01%
==========================================
Files 443 443
Lines 36615 36637 +22
==========================================
+ Hits 35887 35905 +18
- Misses 728 732 +4 | Flag | Coverage Δ | |
|---|---|---|
| integration | 98.00% <82.60%> (-0.01%) |
:arrow_down: |
| unit | 98.00% <82.60%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| NonTestCode | 95.85% <82.60%> (-0.03%) |
:arrow_down: |
| OutsideTasks | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
| Files | Coverage Δ | |
|---|---|---|
| helpers/checkpoint_logger/flows.py | 100.00% <100.00%> (ø) |
|
| tasks/base.py | 95.04% <77.77%> (-1.69%) |
:arrow_down: |
the
UploadFlowreliability metrics rely on there being a checkpoint logged for every way the flow can end, whether it's a success or a failure. looking at the data, it appears 40-60% of flow endings aren't captured. this means we can't totally trust our calculated reliability ratei am not totally clear on how celery calls
on_failure()andon_timeout(), but this PR attempts to load any checkpoints data it can find in them and log an error event. ideally this will increase our share of captured endings and make the metrics more accurateon_timeout()is a member on a celeryRequestwhich we've subclassed asBaseCodecovRequest. it doesn't receivekwargsas an argument, but according to docs it has akwargsproperty which presumably holds the kwargs that the task was scheduled with.on_failure()is a member on the task and one of its arguments iskwargs. a non-retriedUploadTaskwill not have any checkpoints data in its kwargs, but i think a retriedUploadTaskand future tasks should at least have a beginning checkpoint.doing this creates a possibility that some endings will be double-counted:
SoftTimeLimitExceptionmay result in bothon_timeout()andon_failure()being calledSoftTimeLimitExceptionallows the task to clean up gracefully. if it takes too long, a hardTimeLimitExceptionis raised? and it's possible if this happens thaton_timeout()will be called twiceon_success(), but i don't know for sure that there are not cases where we log an error and then also wind up inon_failure()oron_retry()