codecov / worker

Code for Background Workers of Codecov
Other
50 stars 10 forks source link

fix: update compute_name and add tests #806

Closed joseph-sentry closed 3 days ago

joseph-sentry commented 5 days ago

we want to handle the case where there is no actual class name when computing the name for a Pytest test.

this commit also adds unit tests for the compute_name function in test_test_results_processor_task.py

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.02%. Comparing base (ad3621c) to head (4c21cfa). Report is 12 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/codecov/worker/pull/806/graphs/tree.svg?width=650&height=150&src=pr&token=BWTOrjBaE5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov)](https://app.codecov.io/gh/codecov/worker/pull/806?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) ```diff @@ Coverage Diff @@ ## main #806 +/- ## ========================================== + Coverage 97.99% 98.02% +0.03% ========================================== Files 443 444 +1 Lines 36448 36488 +40 ========================================== + Hits 35716 35769 +53 + Misses 732 719 -13 ``` | [Flag](https://app.codecov.io/gh/codecov/worker/pull/806/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/codecov/worker/pull/806/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `98.02% <100.00%> (+0.03%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/codecov/worker/pull/806/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `98.02% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/codecov/worker/pull/806/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [NonTestCode](https://app.codecov.io/gh/codecov/worker/pull/806/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `95.93% <100.00%> (+0.10%)` | :arrow_up: | | [OutsideTasks](https://app.codecov.io/gh/codecov/worker/pull/806/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `98.00% <ø> (+0.03%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/codecov/worker/pull/806?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [tasks/test\_results\_processor.py](https://app.codecov.io/gh/codecov/worker/pull/806?src=pr&el=tree&filepath=tasks%2Ftest_results_processor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#diff-dGFza3MvdGVzdF9yZXN1bHRzX3Byb2Nlc3Nvci5weQ==) | `97.18% <100.00%> (+2.91%)` | :arrow_up: | | [...sks/tests/unit/test\_test\_results\_processor\_task.py](https://app.codecov.io/gh/codecov/worker/pull/806?src=pr&el=tree&filepath=tasks%2Ftests%2Funit%2Ftest_test_results_processor_task.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#diff-dGFza3MvdGVzdHMvdW5pdC90ZXN0X3Rlc3RfcmVzdWx0c19wcm9jZXNzb3JfdGFzay5weQ==) | `100.00% <100.00%> (ø)` | | ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/codecov/worker/pull/806/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov)
codecov-notifications[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   97.99%   98.02%   +0.03%     
==========================================
  Files         443      444       +1     
  Lines       36448    36488      +40     
==========================================
+ Hits        35716    35769      +53     
+ Misses        732      719      -13     
Flag Coverage Δ
integration 98.02% <100.00%> (+0.03%) :arrow_up:
unit 98.02% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.93% <100.00%> (+0.10%) :arrow_up:
OutsideTasks 98.00% <ø> (+0.03%) :arrow_up:
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.18% <100.00%> (+2.91%) :arrow_up:
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

codecov-qa[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.02%. Comparing base (ad3621c) to head (4c21cfa). Report is 12 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   97.99%   98.02%   +0.03%     
==========================================
  Files         443      444       +1     
  Lines       36448    36488      +40     
==========================================
+ Hits        35716    35769      +53     
+ Misses        732      719      -13     
Flag Coverage Δ
integration 98.02% <100.00%> (+0.03%) :arrow_up:
unit 98.02% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.93% <100.00%> (+0.10%) :arrow_up:
OutsideTasks 98.00% <ø> (+0.03%) :arrow_up:
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.18% <100.00%> (+2.91%) :arrow_up:
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

codecov-public-qa[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.02%. Comparing base (ad3621c) to head (4c21cfa). Report is 11 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #806      +/-   ##
==========================================
+ Coverage   97.99%   98.02%   +0.03%     
==========================================
  Files         443      444       +1     
  Lines       36448    36488      +40     
==========================================
+ Hits        35716    35769      +53     
+ Misses        732      719      -13     
Flag Coverage Δ
integration 98.02% <100.00%> (+0.03%) :arrow_up:
unit 98.02% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.93% <100.00%> (+0.10%) :arrow_up:
OutsideTasks 98.00% <ø> (+0.03%) :arrow_up:
Files Coverage Δ
tasks/test_results_processor.py 97.18% <100.00%> (+2.91%) :arrow_up:
...sks/tests/unit/test_test_results_processor_task.py 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes