codecov / worker

Code for Background Workers of Codecov
Other
50 stars 10 forks source link

Fix ReducedError to make it more similar to Django Model #808

Closed michelletran-codecov closed 5 days ago

michelletran-codecov commented 5 days ago

In particular, this table doesn't actually have an external id.

This was pulled out from #729

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.98%. Comparing base (ad3621c) to head (d23d5bd). Report is 3 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
database/models/reports.py 85.71% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/codecov/worker/pull/808/graphs/tree.svg?width=650&height=150&src=pr&token=BWTOrjBaE5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov)](https://app.codecov.io/gh/codecov/worker/pull/808?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) ```diff @@ Coverage Diff @@ ## main #808 +/- ## ========================================== - Coverage 97.99% 97.98% -0.01% ========================================== Files 443 443 Lines 36448 36454 +6 ========================================== + Hits 35716 35721 +5 - Misses 732 733 +1 ``` | [Flag](https://app.codecov.io/gh/codecov/worker/pull/808/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/codecov/worker/pull/808/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `97.98% <85.71%> (-0.01%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/codecov/worker/pull/808/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `97.98% <85.71%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/codecov/worker/pull/808/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [NonTestCode](https://app.codecov.io/gh/codecov/worker/pull/808/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `95.83% <85.71%> (-0.01%)` | :arrow_down: | | [OutsideTasks](https://app.codecov.io/gh/codecov/worker/pull/808/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `97.96% <85.71%> (-0.01%)` | :arrow_down: | | [Files with missing lines](https://app.codecov.io/gh/codecov/worker/pull/808?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [database/models/reports.py](https://app.codecov.io/gh/codecov/worker/pull/808?src=pr&el=tree&filepath=database%2Fmodels%2Freports.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#diff-ZGF0YWJhc2UvbW9kZWxzL3JlcG9ydHMucHk=) | `99.09% <85.71%> (-0.45%)` | :arrow_down: |
codecov-qa[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.98%. Comparing base (ad3621c) to head (d23d5bd). Report is 3 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
database/models/reports.py 85.71% 1 Missing :warning:

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         443      443              
  Lines       36448    36454       +6     
==========================================
+ Hits        35716    35721       +5     
- Misses        732      733       +1     
Flag Coverage Δ
integration 97.98% <85.71%> (-0.01%) :arrow_down:
unit 97.98% <85.71%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.83% <85.71%> (-0.01%) :arrow_down:
OutsideTasks 97.96% <85.71%> (-0.01%) :arrow_down:
Files with missing lines Coverage Δ
database/models/reports.py 99.09% <85.71%> (-0.45%) :arrow_down:
codecov-notifications[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
database/models/reports.py 85.71% 1 Missing :warning:

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         443      443              
  Lines       36448    36454       +6     
==========================================
+ Hits        35716    35721       +5     
- Misses        732      733       +1     
Flag Coverage Δ
integration 97.98% <85.71%> (-0.01%) :arrow_down:
unit 97.98% <85.71%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.83% <85.71%> (-0.01%) :arrow_down:
OutsideTasks 97.96% <85.71%> (-0.01%) :arrow_down:
Files with missing lines Coverage Δ
database/models/reports.py 99.09% <85.71%> (-0.45%) :arrow_down:
codecov-public-qa[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.98%. Comparing base (ad3621c) to head (d23d5bd).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #808      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         443      443              
  Lines       36448    36454       +6     
==========================================
+ Hits        35716    35721       +5     
- Misses        732      733       +1     
Flag Coverage Δ
integration 97.98% <85.71%> (-0.01%) :arrow_down:
unit 97.98% <85.71%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.83% <85.71%> (-0.01%) :arrow_down:
OutsideTasks 97.96% <85.71%> (-0.01%) :arrow_down:
Files Coverage Δ
database/models/reports.py 99.09% <85.71%> (-0.45%) :arrow_down: