Closed matt-codecov closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.99%. Comparing base (
6b1f38e
) to head (0659eb5
). Report is 6 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 446 446
Lines 36568 36621 +53
=======================================
+ Hits 35835 35888 +53
Misses 733 733
Flag | Coverage Δ | |
---|---|---|
integration | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.85% <100.00%> (+0.01%) |
:arrow_up: |
OutsideTasks | 97.97% <100.00%> (+<0.01%) |
:arrow_up: |
Files with missing lines | Coverage Δ | |
---|---|---|
helpers/log_context.py | 98.61% <100.00%> (+1.46%) |
:arrow_up: |
helpers/logging_config.py | 82.22% <100.00%> (+0.40%) |
:arrow_up: |
helpers/tests/unit/test_log_context.py | 100.00% <100.00%> (ø) |
|
helpers/tests/unit/test_logging_config.py | 100.00% <100.00%> (ø) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.99%. Comparing base (
6b1f38e
) to head (0659eb5
). Report is 6 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 446 446
Lines 36568 36621 +53
=======================================
+ Hits 35835 35888 +53
Misses 733 733
Flag | Coverage Δ | |
---|---|---|
integration | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.85% <100.00%> (+0.01%) |
:arrow_up: |
OutsideTasks | 97.97% <100.00%> (+<0.01%) |
:arrow_up: |
Files with missing lines | Coverage Δ | |
---|---|---|
helpers/log_context.py | 98.61% <100.00%> (+1.46%) |
:arrow_up: |
helpers/logging_config.py | 82.22% <100.00%> (+0.40%) |
:arrow_up: |
helpers/tests/unit/test_log_context.py | 100.00% <100.00%> (ø) |
|
helpers/tests/unit/test_logging_config.py | 100.00% <100.00%> (ø) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.99%. Comparing base (
6b1f38e
) to head (0659eb5
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #813 +/- ##
=======================================
Coverage 97.99% 97.99%
=======================================
Files 446 446
Lines 36568 36621 +53
=======================================
+ Hits 35835 35888 +53
Misses 733 733
Flag | Coverage Δ | |
---|---|---|
integration | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 97.99% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.85% <100.00%> (+0.01%) |
:arrow_up: |
OutsideTasks | 97.97% <100.00%> (+<0.01%) |
:arrow_up: |
Files | Coverage Δ | |
---|---|---|
helpers/log_context.py | 98.61% <100.00%> (+1.46%) |
:arrow_up: |
helpers/logging_config.py | 82.22% <100.00%> (+0.40%) |
:arrow_up: |
helpers/tests/unit/test_log_context.py | 100.00% <100.00%> (ø) |
|
helpers/tests/unit/test_logging_config.py | 100.00% <100.00%> (ø) |
Attention: Patch coverage is 43.07692%
with 37 lines
in your changes missing coverage. Please review.
Project coverage is 97.27%. Comparing base (
6b1f38e
) to head (0659eb5
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
@@ Coverage Diff @@
## main #813 +/- ##
==========================================
- Coverage 97.40% 97.27% -0.13%
==========================================
Files 441 441
Lines 36564 36576 +12
==========================================
- Hits 35614 35581 -33
- Misses 950 995 +45
Components | Coverage Δ | |
---|---|---|
NonTestCode | 94.85% <44.44%> (-0.07%) |
:arrow_down: |
OutsideTasks | 97.48% <43.07%> (-0.15%) |
:arrow_down: |
Files with missing lines | Coverage Δ | |
---|---|---|
helpers/logging_config.py | 53.33% <0.00%> (+0.30%) |
:arrow_up: |
helpers/tests/unit/test_logging_config.py | 83.87% <80.00%> (-16.13%) |
:arrow_down: |
helpers/tests/unit/test_log_context.py | 56.52% <26.66%> (-43.48%) |
:arrow_down: |
helpers/log_context.py | 37.50% <45.45%> (-13.82%) |
:arrow_down: |
currently worker logs have celery task information that you can query in GCP Logs Explorer with something like
those fields are still there, but this PR adds a lot more:
jsonPayload.context.task_name
andjsonPayload.context.task_id
jsonPayload.context.repo_name
andjsonPayload.context.repo_id
jsonPayload.context.owner_name
,jsonPayload.context.owner_service
,jsonPayload.context.owner_id
jsonPayload.context.commit_sha
andjsonPayload.context.commit_id
commitid
but here the SHA iscommit_sha
and the database ID iscommit_id
jsonPayload.context.sentry_trace_id
some queries you'll be able to run in GCP Logs Explorer:
some fields will be nulled out. for example
SyncRepos
is an owner-scoped operation so it will have owner info but not repo/commit info. but uploads are commit-specific soUpload
should have commit, repo, and owner info.we log URLs that include owner/repo names in many places so adding them to the auto-populated log context doesn't introduce any new concerns