Closed Swatinem closed 4 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.01%. Comparing base (
02c2e2b
) to head (48ae32b
). Report is 3 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
All modified and coverable lines are covered by tests :white_check_mark:
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 446 446
Lines 36619 36649 +30
=======================================
+ Hits 35892 35923 +31
+ Misses 727 726 -1
Flag | Coverage Δ | |
---|---|---|
integration | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.90% <100.00%> (+<0.01%) |
:arrow_up: |
OutsideTasks | 98.00% <100.00%> (+<0.01%) |
:arrow_up: |
Files with missing lines | Coverage Δ | |
---|---|---|
...rvices/notification/notifiers/codecov_slack_app.py | 100.00% <100.00%> (ø) |
|
services/notification/notifiers/mixins/status.py | 98.17% <100.00%> (-0.02%) |
:arrow_down: |
tasks/notify.py | 95.92% <100.00%> (ø) |
|
tasks/tests/integration/test_notify_task.py | 100.00% <100.00%> (ø) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.01%. Comparing base (
02c2e2b
) to head (48ae32b
). Report is 3 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 446 446
Lines 36619 36649 +30
=======================================
+ Hits 35892 35923 +31
+ Misses 727 726 -1
Flag | Coverage Δ | |
---|---|---|
integration | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.90% <100.00%> (+<0.01%) |
:arrow_up: |
OutsideTasks | 98.00% <100.00%> (+<0.01%) |
:arrow_up: |
Files with missing lines | Coverage Δ | |
---|---|---|
...rvices/notification/notifiers/codecov_slack_app.py | 100.00% <100.00%> (ø) |
|
services/notification/notifiers/mixins/status.py | 98.17% <100.00%> (-0.02%) |
:arrow_down: |
tasks/notify.py | 95.92% <100.00%> (ø) |
|
tasks/tests/integration/test_notify_task.py | 100.00% <100.00%> (ø) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.01%. Comparing base (
02c2e2b
) to head (48ae32b
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #816 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 446 446
Lines 36619 36649 +30
=======================================
+ Hits 35892 35923 +31
+ Misses 727 726 -1
Flag | Coverage Δ | |
---|---|---|
integration | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
unit | 98.01% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.90% <100.00%> (+<0.01%) |
:arrow_up: |
OutsideTasks | 98.00% <100.00%> (+<0.01%) |
:arrow_up: |
Files | Coverage Δ | |
---|---|---|
...rvices/notification/notifiers/codecov_slack_app.py | 100.00% <100.00%> (ø) |
|
services/notification/notifiers/mixins/status.py | 98.17% <100.00%> (-0.02%) |
:arrow_down: |
tasks/notify.py | 95.92% <100.00%> (ø) |
|
tasks/tests/integration/test_notify_task.py | 100.00% <100.00%> (ø) |
There were a couple of errors spread around the notification code assuming that a
head.report
always exists, which is not necessarily the case.In particular that would be the case when using
empty-upload
ormanual_trigger
.Fixes WORKER-P6A