Closed Swatinem closed 4 hours ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.84%. Comparing base (
1539efe
) to head (27a7afe
). Report is 1 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
All modified and coverable lines are covered by tests :white_check_mark:
@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 97.82% 97.84% +0.01%
==========================================
Files 444 444
Lines 36467 36345 -122
==========================================
- Hits 35674 35561 -113
+ Misses 793 784 -9
Flag | Coverage Δ | |
---|---|---|
integration | 97.84% <100.00%> (+0.01%) |
:arrow_up: |
unit | 97.84% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.48% <100.00%> (+0.04%) |
:arrow_up: |
OutsideTasks | 97.98% <ø> (+0.02%) |
:arrow_up: |
Files with missing lines | Coverage Δ | |
---|---|---|
helpers/parallel_upload_processing.py | 100.00% <ø> (+38.09%) |
:arrow_up: |
tasks/tests/unit/test_upload_processing_task.py | 100.00% <100.00%> (ø) |
|
tasks/upload_processor.py | 98.56% <100.00%> (+0.75%) |
:arrow_up: |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.84%. Comparing base (
1539efe
) to head (27a7afe
). Report is 1 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 97.82% 97.84% +0.01%
==========================================
Files 444 444
Lines 36467 36345 -122
==========================================
- Hits 35674 35561 -113
+ Misses 793 784 -9
Flag | Coverage Δ | |
---|---|---|
integration | 97.84% <100.00%> (+0.01%) |
:arrow_up: |
unit | 97.84% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.48% <100.00%> (+0.04%) |
:arrow_up: |
OutsideTasks | 97.98% <ø> (+0.02%) |
:arrow_up: |
Files with missing lines | Coverage Δ | |
---|---|---|
helpers/parallel_upload_processing.py | 100.00% <ø> (+38.09%) |
:arrow_up: |
tasks/tests/unit/test_upload_processing_task.py | 100.00% <100.00%> (ø) |
|
tasks/upload_processor.py | 98.56% <100.00%> (+0.75%) |
:arrow_up: |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.84%. Comparing base (
1539efe
) to head (27a7afe
).
:white_check_mark: All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 97.82% 97.84% +0.01%
==========================================
Files 444 444
Lines 36467 36345 -122
==========================================
- Hits 35674 35561 -113
+ Misses 793 784 -9
Flag | Coverage Δ | |
---|---|---|
integration | 97.84% <100.00%> (+0.01%) |
:arrow_up: |
unit | 97.84% <100.00%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Components | Coverage Δ | |
---|---|---|
NonTestCode | 95.48% <100.00%> (+0.04%) |
:arrow_up: |
OutsideTasks | 97.98% <ø> (+0.02%) |
:arrow_up: |
Files | Coverage Δ | |
---|---|---|
helpers/parallel_upload_processing.py | 100.00% <ø> (+38.09%) |
:arrow_up: |
tasks/tests/unit/test_upload_processing_task.py | 100.00% <100.00%> (ø) |
|
tasks/upload_processor.py | 98.56% <100.00%> (+0.75%) |
:arrow_up: |
So far, this removes the lock handling, and the code to store the "experiment" reports, along with other codepaths only relevant for serial processing mode.
A bunch of tests are also being removed which would have asserted that
UploadProcessor
is updating the finalreport_json
, which is not the case anymore, as that logic now happens inUploadFinisher
only.