codecov / worker

Code for Background Workers of Codecov
Other
50 stars 10 forks source link

Hardcode parallel-only mode in `UploadProcessor` #824

Closed Swatinem closed 4 hours ago

Swatinem commented 5 hours ago

So far, this removes the lock handling, and the code to store the "experiment" reports, along with other codepaths only relevant for serial processing mode.

A bunch of tests are also being removed which would have asserted that UploadProcessor is updating the final report_json, which is not the case anymore, as that logic now happens in UploadFinisher only.

codecov[bot] commented 5 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.84%. Comparing base (1539efe) to head (27a7afe). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/codecov/worker/pull/824/graphs/tree.svg?width=650&height=150&src=pr&token=BWTOrjBaE5&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov)](https://app.codecov.io/gh/codecov/worker/pull/824?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) ```diff @@ Coverage Diff @@ ## main #824 +/- ## ========================================== + Coverage 97.82% 97.84% +0.01% ========================================== Files 444 444 Lines 36467 36345 -122 ========================================== - Hits 35674 35561 -113 + Misses 793 784 -9 ``` | [Flag](https://app.codecov.io/gh/codecov/worker/pull/824/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [integration](https://app.codecov.io/gh/codecov/worker/pull/824/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `97.84% <100.00%> (+0.01%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/codecov/worker/pull/824/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `97.84% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#carryforward-flags-in-the-pull-request-comment) to find out more. | [Components](https://app.codecov.io/gh/codecov/worker/pull/824/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [NonTestCode](https://app.codecov.io/gh/codecov/worker/pull/824/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `95.48% <100.00%> (+0.04%)` | :arrow_up: | | [OutsideTasks](https://app.codecov.io/gh/codecov/worker/pull/824/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | `97.98% <ø> (+0.02%)` | :arrow_up: | | [Files with missing lines](https://app.codecov.io/gh/codecov/worker/pull/824?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov) | Coverage Δ | | |---|---|---| | [helpers/parallel\_upload\_processing.py](https://app.codecov.io/gh/codecov/worker/pull/824?src=pr&el=tree&filepath=helpers%2Fparallel_upload_processing.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#diff-aGVscGVycy9wYXJhbGxlbF91cGxvYWRfcHJvY2Vzc2luZy5weQ==) | `100.00% <ø> (+38.09%)` | :arrow_up: | | [tasks/tests/unit/test\_upload\_processing\_task.py](https://app.codecov.io/gh/codecov/worker/pull/824?src=pr&el=tree&filepath=tasks%2Ftests%2Funit%2Ftest_upload_processing_task.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#diff-dGFza3MvdGVzdHMvdW5pdC90ZXN0X3VwbG9hZF9wcm9jZXNzaW5nX3Rhc2sucHk=) | `100.00% <100.00%> (ø)` | | | [tasks/upload\_processor.py](https://app.codecov.io/gh/codecov/worker/pull/824?src=pr&el=tree&filepath=tasks%2Fupload_processor.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov#diff-dGFza3MvdXBsb2FkX3Byb2Nlc3Nvci5weQ==) | `98.56% <100.00%> (+0.75%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/codecov/worker/pull/824/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=codecov)
codecov-staging[bot] commented 5 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
+ Coverage   97.82%   97.84%   +0.01%     
==========================================
  Files         444      444              
  Lines       36467    36345     -122     
==========================================
- Hits        35674    35561     -113     
+ Misses        793      784       -9     
Flag Coverage Δ
integration 97.84% <100.00%> (+0.01%) :arrow_up:
unit 97.84% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.48% <100.00%> (+0.04%) :arrow_up:
OutsideTasks 97.98% <ø> (+0.02%) :arrow_up:
Files with missing lines Coverage Δ
helpers/parallel_upload_processing.py 100.00% <ø> (+38.09%) :arrow_up:
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
tasks/upload_processor.py 98.56% <100.00%> (+0.75%) :arrow_up:

... and 1 file with indirect coverage changes

codecov-qa[bot] commented 5 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.84%. Comparing base (1539efe) to head (27a7afe). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
+ Coverage   97.82%   97.84%   +0.01%     
==========================================
  Files         444      444              
  Lines       36467    36345     -122     
==========================================
- Hits        35674    35561     -113     
+ Misses        793      784       -9     
Flag Coverage Δ
integration 97.84% <100.00%> (+0.01%) :arrow_up:
unit 97.84% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.48% <100.00%> (+0.04%) :arrow_up:
OutsideTasks 97.98% <ø> (+0.02%) :arrow_up:
Files with missing lines Coverage Δ
helpers/parallel_upload_processing.py 100.00% <ø> (+38.09%) :arrow_up:
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
tasks/upload_processor.py 98.56% <100.00%> (+0.75%) :arrow_up:

... and 1 file with indirect coverage changes

codecov-public-qa[bot] commented 5 hours ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.84%. Comparing base (1539efe) to head (27a7afe).

:white_check_mark: All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
+ Coverage   97.82%   97.84%   +0.01%     
==========================================
  Files         444      444              
  Lines       36467    36345     -122     
==========================================
- Hits        35674    35561     -113     
+ Misses        793      784       -9     
Flag Coverage Δ
integration 97.84% <100.00%> (+0.01%) :arrow_up:
unit 97.84% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.48% <100.00%> (+0.04%) :arrow_up:
OutsideTasks 97.98% <ø> (+0.02%) :arrow_up:
Files Coverage Δ
helpers/parallel_upload_processing.py 100.00% <ø> (+38.09%) :arrow_up:
tasks/tests/unit/test_upload_processing_task.py 100.00% <100.00%> (ø)
tasks/upload_processor.py 98.56% <100.00%> (+0.75%) :arrow_up:

... and 1 file with indirect coverage changes