codecrafters-io / build-your-own-redis

Definition for the redis challenge.
https://app.codecrafters.io/courses/redis/overview
MIT License
108 stars 30 forks source link

Better errors for RDB parsing #143

Closed rohitpaulk closed 4 months ago

rohitpaulk commented 4 months ago

In the RDB extension, since we rely on a third-party parser, our error messages aren't very helpful.

Example:

Error while parsing RDB file : unexpected EOF

Just like we do with RESPClient, we should write our own parser that can generate friendly error messages.

Thanks to @knusth for highlighting this!

linear[bot] commented 4 months ago

CC-1076 Better errors for RDB parsing

rohitpaulk commented 4 months ago

Actually wait, ignore this - we're only writing RDB files, user code handles reading. I thought it's the other way around when I created this