search

codecrafters-io / build-your-own-redis

Definition for the redis challenge.
https://app.codecrafters.io/courses/redis/overview
MIT License
108 stars 30 forks source link

[streams] Blocking reads compare strictly #159

Open lipinskipawel opened 4 months ago

lipinskipawel commented 4 months ago

Hello I enjoy your website and implementing your challenges are fun :)

However, I think I faced a small bug during streams stage at "Blocking reads" task. The tester is comparing responses strictly instead of using some sort of containsAll assertion. Is this intentional or I should fix my code?

image

linear[bot] commented 4 months ago

CC-1109 [streams] Blocking reads compare strictly

rohitpaulk commented 4 months ago

Hey @lipinskipawel! Thanks for reporting this, it looks like the official Redis implementation does always return these in the same order as the stream keys in the command.

I'll keep this open so that we can add a note to the instructions + we'll also see if there's an official note either in the Redis docs / source code about this behaviour that we can link to.