search

codecrafters-io / build-your-own-redis

Definition for the redis challenge.
https://app.codecrafters.io/courses/redis/overview
MIT License
128 stars 37 forks source link

CC-1227 Change slug to legacy slug #194

Closed libmartinito closed 4 months ago

linear[bot] commented 4 months ago

CC-1227 Migrate CourseStage#slug with zero downtime

libmartinito commented 4 months ago

can you please confirm if it's fine to ignore breaking tests for now

rohitpaulk commented 4 months ago

can you please confirm if it's fine to ignore breaking tests for now

@libmartinito the failures seem related to this change though - so we'll need them to eventually be passing. If you've got a plan to keep the disruption minimal and only have this failing for an hour or so, that's fine - else we'll need to find a more backward-compatible solution.

libmartinito commented 4 months ago

to avoid making changes to tester versions at this stage, what do you think of keeping around slug? then instead of checking if there are no null course stage slug values in the next stage, we'd check if they're in the correct format?