Clearer handling of expandable list steps

rohitpaulk commented 1 week ago

fix dark mode hover effect
Add NonExpandableStep component and refactor ExpandableStepList logic.

Summary by CodeRabbit

New Features
- Introduced a new NonExpandableStep component to enhance the user experience in the expandable step list.
- Added a hover overlay on non-expandable steps to inform users about completion requirements.
- Expanded Tailwind CSS theme with a new amber color for enhanced styling options.
Bug Fixes
- Updated hover background color for improved visibility in dark mode.
Style
- Enhanced responsive and adaptive styles for light and dark themes in the new component.
- Adjusted hover effects in dark mode for better user experience.

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a new NonExpandableStep component within the ExpandableStepList, designed to visually represent non-expandable steps. It includes a hover overlay that informs users about the completion requirements of previous steps. Additionally, minor updates to the hover styling for dark mode in the Step component are included, along with enhancements to the Tailwind CSS configuration, adding new color definitions and customization options.

Changes

File Path	Change Summary
app/components/expandable-step-list/non-expandable-step.hbs	Introduced `non-expandable-step` component with a hover overlay and responsive styles.
app/components/expandable-step-list/non-expandable-step.ts	Added `NonExpandableStepComponent`, defined its signature, and registered it in the Glint environment.
app/components/expandable-step-list/step.hbs	Updated hover background color class for dark mode styling.
app/components/expandable-step-list/step.ts	Modified logic in `handleDidUpdateIsComplete` to allow broader conditions for previous step completion.
tailwind.config.js	Added `amber` color to the theme and expanded customization options for colors and variants.

Possibly related PRs

#2022: This PR involves changes to the header.hbs file, which includes updates to CSS class names affecting dark mode styling, similar to the changes made in the main PR regarding dark mode enhancements.
#2023: This PR modifies dark mode border styles in various components, which aligns with the main PR's focus on improving dark mode visual consistency.
#2024: This PR introduces dark mode styling changes across multiple components, directly relating to the main PR's enhancements for dark mode.
#2033: This PR focuses on enhancing dark mode styling across various components, which is a key aspect of the main PR's objectives.
#2085: This PR modifies dark mode styles in the instructions-card.hbs file, which is relevant to the main PR's updates on dark mode components.
#2138: This PR introduces new components that manage modal overlays, which may relate to the user experience improvements in the main PR.
#2331: This PR adds a new overlay component that manages the display of incomplete steps, which could be relevant to the user experience enhancements in the main PR.
#2332: This PR introduces modal components that indicate step completion, which aligns with the main PR's focus on improving user interaction and experience.

🐰 In the garden of code, we hop and play,
New steps emerge, brightening the way.
With overlays and styles, we dance in delight,
Expanding our list, making everything right!
So let’s celebrate, with a joyful cheer,
For every new change brings us closer, my dear! 🌼✨

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 week ago

Bundle Report

Changes will increase total bundle size by 3.04kB (0.01%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes

| Bundle name | Size | Change | | ----------- | ---- | ------ | | client-array-push | 35.76MB | 3.04kB (0.01%) :arrow_up: |

github-actions[bot] commented 1 week ago

Test Results

1 files ±0 1 suites ±0 6m 26s :stopwatch: -7s 574 tests ±0 537 :white_check_mark: - 1 36 :zzz: ±0 0 :x: ±0 1 :fire: +1 589 runs ±0 551 :white_check_mark: - 2 36 :zzz: ±0 1 :x: +1 1 :fire: +1

For more details on these errors, see this check.

Results for commit 9106a9ca. ± Comparison against base commit c9ae4928.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 week ago

:x: 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
574	1	573	0

View the top 1 failed tests by shortest run time

> > ``` > Chrome 129.0 Acceptance | concepts-test: tracked progress is rendered properly on page visit > ``` > >

Stack Traces | 0.394s run time

> > > > > ``` > > No failure message available > > ``` > >

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

codecrafters-io / frontend