Open VasylMarchuk opened 2 hours ago
[!IMPORTANT]
Review skipped
Draft detected.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
ββ1 filesβ Β±0ββββ1 suitesβ Β±0βββ6m 48s β±οΈ - 1m 6s 583 tests +1ββ543 β +1ββ40 π€ Β±0ββ0 β Β±0β 598 runsβ +1ββ558 β +1ββ40 π€ Β±0ββ0 β Β±0β
Results for commit 978803af.βΒ± Comparison against base commit d9846e1c.
:recycle: This comment has been updated with latest results.
Attention: Patch coverage is 81.81818%
with 2 lines
in your changes missing coverage. Please review.
:white_check_mark: All tests successful. No failed tests found.
Files with missing lines | Patch % | Lines |
---|---|---|
app/services/clipboard.ts | 81.81% | 1 Missing and 1 partial :warning: |
:loudspeaker: Thoughts on this report? Let us know!
Changes will decrease total bundle size by 1.81kB (-0.01%) :arrow_down:. This is within the configured threshold :white_check_mark:
Brief
This unifies all interactions with the Clipboard by adding a new service
clipboard
, and by using it in all components that previously interacted withnavigator.clipboard
, instead of custom implementations (each slightly different) in approximately 9 different places.In addition, when running the tests suite, all
navigator.clipboard.*
API methods are stubbed with Sinon fakes before each test, and un-stubbed after, thus preventing any potential side-effects.Details
TBD
Checklist:
[percy]
in the message to trigger)