Don't show "tests failed" for a system submission

rohitpaulk commented 1 week ago

Summary by CodeRabbit

New Features
- Updated test runner card messages and instructions based on user interaction with the testing functionality.
- Added instructional messages to enhance user guidance for running tests.
Bug Fixes
- Improved logic for determining user test engagement, enhancing the overall user experience.
Tests
- Enhanced acceptance tests to verify course completion logic and instructional message visibility.
Documentation
- Added new property to the second-stage instructions card to provide access to step-specific instructions.

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the Handlebars template and the underlying logic of the RunTestsInstructionsComponent. The template now checks if the user has previously run tests for the current stage, altering the displayed status messages and instructions accordingly. Additionally, the component's logic is refined with the introduction of a new getter to assess user interaction with the test runner. Updates to acceptance tests and the structure of instructional steps further enhance the verification of course completion and user guidance.

Changes

File	Change Summary
app/components/course-page/course-stage-step/test-runner-card/run-tests-instructions.hbs	Updated conditional logic to check if the user has run tests for the stage at least once, affecting status messages and instructions.
app/components/course-page/course-stage-step/test-runner-card/run-tests-instructions.ts	Removed `lastSubmissionWasForCurrentStage` getter; added `userHasRunTestsForStageAtLeastOnce` getter to refine user interaction logic.
tests/acceptance/course-page/complete-second-stage-test.js	Added assertions to verify completion status and instructional messages for the second stage.
tests/pages/components/course-page/course-stage-step/second-stage-instructions-card.ts	Added `instructions` property to `steps` collection for enhanced access to instructional text.

Possibly related PRs

#1742: Modifications to course stage indicators' display logic, potentially relating to user interactions in the test runner card.
#2013: Introduction of dark mode styling that could impact the presentation of test runner card messages.
#2045: Enhancements for dark mode styles may relate to the visual presentation of the test runner card.
#2367: Modifications to second stage instructions may directly impact how the test runner card's instructions are presented.
#2407: Tweaks to second stage instructions for the Solution experiment may affect user interaction with the test runner card's instructions.

🐰 In the garden of code, we play,
With tests and messages, bright as day.
A runner's guide, now clear and bright,
For every stage, we set it right.
So hop along, dear coder friends,
Together we'll make this journey blend! 🌼

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 week ago

Test Results

1 files ±0 1 suites ±0 5m 53s ⏱️ - 1m 37s 583 tests ±0 543 ✅ ±0 40 💤 ±0 0 ❌ ±0 598 runs ±0 558 ✅ ±0 40 💤 ±0 0 ❌ ±0

Results for commit 87c00521. ± Comparison against base commit 72da7ca1.

This pull request removes 583 and adds 583 tests. Note that renamed tests count towards both.

``` Chrome 130.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a collection Chrome 130.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a course page Chrome 130.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a track page Chrome 130.0 ‑ Acceptance | Meta tags: it has default meta image when visiting /catalog Chrome 130.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: accepting offer when not logged in redirects to login Chrome 130.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: can accept offer Chrome 130.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when logged in Chrome 130.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when not logged in Chrome 130.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if affiliate link is invalid Chrome 130.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if course slug is invalid … ``` ``` Chrome 131.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a collection Chrome 131.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a course page Chrome 131.0 ‑ Acceptance | Meta tags: it has custom meta image when visiting a track page Chrome 131.0 ‑ Acceptance | Meta tags: it has default meta image when visiting /catalog Chrome 131.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: accepting offer when not logged in redirects to login Chrome 131.0 ‑ Acceptance | affiliate-course-link-page | accept-offer: can accept offer Chrome 131.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when logged in Chrome 131.0 ‑ Acceptance | affiliate-course-link-page | view: can view affiliate link when not logged in Chrome 131.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if affiliate link is invalid Chrome 131.0 ‑ Acceptance | affiliate-course-link-page | view: redirects to not found if course slug is invalid … ```

This pull request removes 40 skipped tests and adds 40 skipped tests. Note that renamed tests count towards both.

``` Chrome 130.0 ‑ Acceptance | course-page | view-course-stages-test: it should track when the monthly challenge banner is clicked Chrome 130.0 ‑ Integration | Component | code-mirror > Options > allowMultipleSelections: it does something useful with the editor Chrome 130.0 ‑ Integration | Component | code-mirror > Options > autocompletion: it does something useful with the editor Chrome 130.0 ‑ Integration | Component | code-mirror > Options > bracketMatching: it does something useful with the editor Chrome 130.0 ‑ Integration | Component | code-mirror > Options > closeBrackets: it does something useful with the editor Chrome 130.0 ‑ Integration | Component | code-mirror > Options > collapseUnchanged: it does something useful with the editor Chrome 130.0 ‑ Integration | Component | code-mirror > Options > crosshairCursor: it does something useful with the editor Chrome 130.0 ‑ Integration | Component | code-mirror > Options > drawSelection: it does something useful with the editor Chrome 130.0 ‑ Integration | Component | code-mirror > Options > dropCursor: it does something useful with the editor Chrome 130.0 ‑ Integration | Component | code-mirror > Options > editable: it does something useful with the editor … ``` ``` Chrome 131.0 ‑ Acceptance | course-page | view-course-stages-test: it should track when the monthly challenge banner is clicked Chrome 131.0 ‑ Integration | Component | code-mirror > Options > allowMultipleSelections: it does something useful with the editor Chrome 131.0 ‑ Integration | Component | code-mirror > Options > autocompletion: it does something useful with the editor Chrome 131.0 ‑ Integration | Component | code-mirror > Options > bracketMatching: it does something useful with the editor Chrome 131.0 ‑ Integration | Component | code-mirror > Options > closeBrackets: it does something useful with the editor Chrome 131.0 ‑ Integration | Component | code-mirror > Options > collapseUnchanged: it does something useful with the editor Chrome 131.0 ‑ Integration | Component | code-mirror > Options > crosshairCursor: it does something useful with the editor Chrome 131.0 ‑ Integration | Component | code-mirror > Options > drawSelection: it does something useful with the editor Chrome 131.0 ‑ Integration | Component | code-mirror > Options > dropCursor: it does something useful with the editor Chrome 131.0 ‑ Integration | Component | code-mirror > Options > editable: it does something useful with the editor … ```

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] commented 1 week ago

Bundle Report

Changes will increase total bundle size by 1.79kB (0.0%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes

| Bundle name | Size | Change | | ----------- | ---- | ------ | | client-array-push | 35.84MB | 1.79kB (0.0%) :arrow_up: |

codecrafters-io / frontend