search

codecrafters-io / frontend

Rebuild complex systems from scratch
https://app.codecrafters.io/catalog
Other
64 stars 13 forks source link

Recommend Git instead of CLI for stage 2 #2420

Closed rohitpaulk closed 1 week ago

rohitpaulk commented 1 week ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve modifications to the test runner card's template and logic within the RunTestsInstructionsComponent. The template now displays a static recommendation for using the CodeCrafters CLI, regardless of the recommendedClientType. Additionally, the command variants logic has been updated to return both gitVariant and cliVariant under certain conditions. Acceptance tests have also been updated to reflect these changes, particularly in the expected command outputs for different stages.

Changes

File Change Summary
app/components/course-page/course-stage-step/test-runner-card/run-tests-instructions.hbs Removed conditional block for CLI recommendation; now displays a static recommendation in a <div> element.
app/components/course-page/course-stage-step/test-runner-card/run-tests-instructions.ts Updated commandVariants method to return both gitVariant and cliVariant when recommendedClientType is not 'cli'; modified recommendedClientType logic to include course stage checks.
tests/acceptance/course-page/test-runner-card-test.js Updated acceptance tests for stage 2 to expect Git commands instead of CLI; added new test case for stage 3 to verify CLI command behavior; assertions modified to reflect new expected command outputs.

Possibly related PRs

🐇 In the meadow where bunnies hop,
A change was made, we can't stop!
Commands now dance, both git and cli,
Recommendations shining, oh my, oh my!
With tests updated, all is bright,
Hooray for changes, what a delight! 🥕✨

[!WARNING]

Rate limit exceeded

@rohitpaulk has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 13 seconds before requesting another review.

⌛ How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
🚦 How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://docs.coderabbit.ai/faq) for further information.
📥 Commits Reviewing files that changed from the base of the PR and between 74b802abc5e97786c6d870db75518359b272000f and f57e9fe040933b3b563337ca6aa43e1f3c696db6.
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 week ago

Test Results

  1 files  ±0    1 suites  ±0   6m 7s ⏱️ -2s 584 tests +1  543 ✅ ±0  40 💤 ±0  0 ❌ ±0  1 🔥 +1  599 runs  +1  557 ✅  - 1  40 💤 ±0  1 ❌ +1  1 🔥 +1 

For more details on these errors, see this check.

Results for commit edc77094. ± Comparison against base commit 71bc7bb0.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. ``` Chrome 131.0 ‑ Acceptance | course-page | test-runner-card: suggests CLI by default for stage 2 ``` ``` Chrome 131.0 ‑ Acceptance | course-page | test-runner-card: suggests CLI by default for stage 3 Chrome 131.0 ‑ Acceptance | course-page | test-runner-card: suggests Git for stage 2 ```

:recycle: This comment has been updated with latest results.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] commented 1 week ago

Bundle Report

Changes will increase total bundle size by 1.69kB (0.0%) :arrow_up:. This is within the configured threshold :white_check_mark:

Detailed changes | Bundle name | Size | Change | | ----------- | ---- | ------ | | client-array-push | 35.87MB | 1.69kB (0.0%) :arrow_up: |