Fix test failure - Githubissues

rohitpaulk commented 1 year ago

@VasylMarchuk creating this so you can leave any questions/progress updates on the test failure task 🙂

rohitpaulk commented 1 year ago

@VasylMarchuk fyi, added a comment here: https://github.com/codecrafters-io/frontend/pull/454#issuecomment-1584526160.

VasylMarchuk commented 1 year ago

Ok great @rohitpaulk, all tests are now passing locally for me!

I'm trying to add an additional and more isolated/verbose ember exam run to the GH action and see if running without Percy & coverage goes any different.

VasylMarchuk commented 1 year ago

Hey @rohitpaulk !

I have attempted several different approaches to debug it, but it still seems to persist on GitHub, and I still can't replicate it on my local machine.

Nevertheless, I prepared a PR (https://github.com/codecrafters-io/frontend/pull/460) with several changes that will make debugging of this issue easier in the future:

Added output of ember & percy versions to GH action (it matches the latest on my machine)
Fixed ProgressBanner test — it freezes on my machine and was occasionally freezing on GitHub too, causing the tests to "run" for 10 minutes until terminated by GitHub, instead of taking the usual 3
Made the tests run in single thread mode, to get consistent and repeatable test sequence
Skipped the "can upvote / downvote comments" test in course-stage-comments to see if this fixes the build permanently

codecrafters-io / frontend

Fix test failure #450