search

codecurious-bln / CC-website

Jekyll Site for Code Curious it deploys to:
https://www.codecurious.org
10 stars 9 forks source link

Add JS testing workshop (30.11.2019) #53

Closed ferbsx closed 4 years ago

ferbsx commented 4 years ago

What type of PR is this? (check all applicable)

Description

Related Issues

48

Mobile & Desktop Screenshots (if there are UI changes)

Added to documentation?

anaschwendler commented 4 years ago

Hey hey @ferbsx that looks alright for me, just wanted to check something:

  1. Should we show this event on the home page? I opened the deploy preview and couldn't see right away
  2. Can you provide a screenshot of how the page looks like?

Thank you! 🎉

ferbsx commented 4 years ago

Hey hey @ferbsx that looks alright for me, just wanted to check something:

  1. Should we show this event on the home page? I opened the deploy preview and couldn't see right away
  2. Can you provide a screenshot of how the page looks like?

Thank you! 🎉

Yes, it should be added to the homepage, I asked Yoni for help and I'm going to set it up now :) But if you want to see it, you can look under this link: https://deploy-preview-53--code-curious.netlify.com/en/events/2019/11/30/js-testing-workshop/

klappradla commented 4 years ago

Some small thing I noticed on the diff: one filename has JS, the other js in the name. Not sure if this plays a role for how files are treated in your website...

Also: how does the headline get generated? I personally think it looks weird to have it Js and would suggest to move to JS in all caps if possible 🤓

ferbsx commented 4 years ago

Some small thing I noticed on the diff: one filename has JS, the other js in the name. Not sure if this plays a role for how files are treated in your website...

Also: how does the headline get generated? I personally think it looks weird to have it Js and would suggest to move to JS in all caps if possible 🤓

yea, I was trying to get the headline to change that's why one of the files is JS.... I will try to get the title to change again, but no promises..

Thank you for reviewing! Having a German native review the German parts is super helpful :)

klappradla commented 4 years ago

I was trying to get the headline to change

I think™ you should just be able to add a:

title: JS Testing workshop

To the section at the top of the file.

shushugah commented 4 years ago

Some small thing I noticed on the diff: one filename has JS, the other js in the name. Not sure if this plays a role for how files are treated in your website...

Also: how does the headline get generated? I personally think it looks weird to have it Js and would suggest to move to JS in all caps if possible 🤓

Since the config.yml uses pretty permalinks, it first looks for a title: Whatever frontmatter, and if none are present (they are not as of this writing) then it copies from the file name.

ferbsx commented 4 years ago

Thank you @klappradla @shushugah @5minpause @anaschwendler for reviewing and helping fix the mistakes <3

klappradla commented 4 years ago

Having a German native review the German parts is super helpful

Feel free to have me translate the whole thing next time, if that's an extra effort on your side.