search

codeday-hom / hit-or-miss

Hit or Miss game - online version
0 stars 1 forks source link

Zuno/word selection #35

Closed Zhouuuuu5 closed 1 year ago

Zhouuuuu5 commented 1 year ago

25 Part 2

  1. Optimization: After clicking the "Roll Dice" button, wait for 1.5 seconds before displaying the dice result.
  2. The wordlist will appear only after the dice result is displayed (use callback). Currently, only the current user can view their own wordlist.
  3. After selecting a word, user should be prevented from selecting other words.
  4. After a word is chosen, word will be broadcasted to all users.
  5. Refactor the useEffect of Dice component. Break it into multiple functions: calculate dice rotation, send the HIT_OR_MISS message, and set wildcardOption state.
robmoore-i commented 1 year ago

@Zhouuuuu5 This PR should target zuno/roll-dice instead of main until zuno/roll-dice gets merged, so that only the changes versus the other branch are shown, instead of this PR's changes including that branch's changes.

Once that branch's PR gets merged, this PR should target main. GitHub will change the target branch automatically once the PR is merged, which is a nice feature.

Zhouuuuu5 commented 1 year ago

@Zhouuuuu5 This PR should target zuno/roll-dice instead of main until zuno/roll-dice gets merged, so that only the changes versus the other branch are shown, instead of this PR's changes including that branch's changes.

Once that branch's PR gets merged, this PR should target main. GitHub will change the target branch automatically once the PR is merged, which is a nice feature.

Thanks for the instruction!

robmoore-i commented 1 year ago

Merged to main here: https://github.com/codeday-hom/hit-or-miss/pull/37